-
Notifications
You must be signed in to change notification settings - Fork 231
SDP-1933: Add SDP Overview Page #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| trailingSlash: false, | ||
| onBrokenAnchors: "ignore", | ||
| onBrokenLinks: "throw", | ||
| onBrokenMarkdownLinks: "throw", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docusaurus 3 dropped markdown.hooks.onBrokenMarkdownLinks, so we move that setting to the supported top-level onBrokenMarkdownLinks: "throw" to stop yarn start from failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you might be looking at it the wrong way around. v3.9 marked siteConfig.onBrokenMarkdownLinks as deprecated, and the warnings are saying to instead use siteConfig.markdown.hooks.onBrokenMarkdownLinks. We updated to the latest docusaurus recently, so you might need to do a yarn install?
Source: https://docusaurus.io/docs/api/docusaurus-config#onBrokenMarkdownLinks
|
Preview is available here: |
ElliotFriend
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lookin' pretty good! one quibble with the config changes, but otherwise looks great!
| trailingSlash: false, | ||
| onBrokenAnchors: "ignore", | ||
| onBrokenLinks: "throw", | ||
| onBrokenMarkdownLinks: "throw", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you might be looking at it the wrong way around. v3.9 marked siteConfig.onBrokenMarkdownLinks as deprecated, and the warnings are saying to instead use siteConfig.markdown.hooks.onBrokenMarkdownLinks. We updated to the latest docusaurus recently, so you might need to do a yarn install?
Source: https://docusaurus.io/docs/api/docusaurus-config#onBrokenMarkdownLinks
| title: Monitoring | ||
| description: Guide to using the Stellar Disbursement Platform CLI | ||
| keywords: [SDP, CLI] | ||
| description: Guide to monitoring SDP via Prometheus and Grafana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch here!
|
|
||
| Graphic representation of flow of funds: | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this SDP1.png image used anywhere else? might be good to remove the file, too, if this is the only reference to it.
As title.