Fix CI wasm discovery picking dependency files#2435
Merged
leighmcculloch merged 1 commit intomainfrom Mar 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CI workflow WASM artifact discovery so verification steps run against the actual built contract WASM rather than dependency WASMs from target/.../release/deps.
Changes:
- Narrow the
findsearch to*/wasm32v1-none/release/*. - Exclude
*/deps/*from WASM discovery in both affected workflows.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test-with-soroban-examples.yml | Updates WASM discovery to avoid selecting dependency WASMs during soroban-examples CI verification. |
| .github/workflows/test-with-openzeppelin-contracts.yml | Updates WASM discovery to avoid selecting dependency WASMs during OpenZeppelin contracts CI verification. |
fnando
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exclude
deps/from thefindcommand that locates built WASM files in the OpenZeppelin contracts and soroban-examples CI workflows. Add-not -path '*/deps/*'and narrow the search to*/wasm32v1-none/release/*.Why
The
find | head -1command was picking up dependency library WASMs fromtarget/wasm32v1-none/release/deps/(e.g.,stellar_tokens.wasm) instead of the actual contract WASM (e.g.,fungible_pausable_example.wasm). This causedspec-verifyand other verification steps to run against library WASMs that contain duplicate spec entries from aggregating multiple token standards, failing the CI for many crates.This is also impacting #2353.