-
Notifications
You must be signed in to change notification settings - Fork 113
Add stellar keys use --clear to clear the default identity.
#2332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,13 +4,23 @@ use crate::{commands::global, config::locator, print::Print}; | |
| pub enum Error { | ||
| #[error(transparent)] | ||
| Config(#[from] locator::Error), | ||
|
|
||
| #[error("Identify name is required unless --clear is specified")] | ||
| NameRequired, | ||
|
|
||
| #[error("Identify name cannot be used with --clear")] | ||
| NameWithClear, | ||
| } | ||
|
|
||
| #[derive(Debug, clap::Parser, Clone)] | ||
| #[group(skip)] | ||
| pub struct Cmd { | ||
| /// Set the default network name. | ||
| pub name: String, | ||
| pub name: Option<String>, | ||
|
|
||
| /// Clear the default source account. | ||
| #[arg(long)] | ||
| pub clear: bool, | ||
|
|
||
| #[command(flatten)] | ||
| pub config_locator: locator::Args, | ||
|
|
@@ -19,14 +29,26 @@ pub struct Cmd { | |
| impl Cmd { | ||
| pub fn run(&self, global_args: &global::Args) -> Result<(), Error> { | ||
| let printer = Print::new(global_args.quiet); | ||
| let _ = self.config_locator.read_identity(&self.name)?; | ||
|
|
||
| self.config_locator.write_default_identity(&self.name)?; | ||
| if self.clear && self.name.is_some() { | ||
| return Err(Error::NameWithClear); | ||
| } | ||
|
|
||
| if !self.clear && self.name.is_none() { | ||
| return Err(Error::NameRequired); | ||
| } | ||
|
Comment on lines
+33
to
+39
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we omitted the bool, then we wouldn't need these condition checks.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having clap manage this might make it easier: |
||
|
|
||
| if self.clear { | ||
| self.config_locator.clear_default_identity()?; | ||
| printer.infoln("The default source account has been cleared".to_string()); | ||
| } else { | ||
| let name = self.name.as_ref().unwrap(); | ||
| let _ = self.config_locator.read_identity(name)?; | ||
|
|
||
| self.config_locator.write_default_identity(name)?; | ||
|
|
||
| printer.infoln(format!( | ||
| "The default source account is set to `{}`", | ||
| self.name, | ||
| )); | ||
| printer.infoln(format!("The default source account is set to `{name}`")); | ||
| } | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we omit the clear: bool, and just make it if name is None, then clear it?