-
Notifications
You must be signed in to change notification settings - Fork 113
Fix/soroban auth signing with ledger #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
elizabethengelman
wants to merge
34
commits into
main
Choose a base branch
from
fix/soroban-auth-signing-with-ledger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an async function more easily
we should be able to have resolve_signer (in arg_parsing) always return a Signer instead of a SigningKey
…-signing-with-ledger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
[TODO: Short statement about what is changing.]
Why
There is currently a workaround for this, in that users can build the tx and then pipe that into simulate/sign/send.
This PR makes that workflow a bit more streamlined by allowing users to sign
contract invoketxs with a ledger directly.Testing
local source key, ledger as auth key
worked before this change ❌
works after this change
ledger as source key, local auth key ✅
❌ error: Ledger cannot reveal private keysledger as source key, ledger as auth key
❌ error: Secure Store does not reveal secret keyKnown limitations
[TODO or N/A]