security: Added confirmation for sensitive operations#301
Closed
Ishaan453 wants to merge 1 commit intosteipete:mainfrom
Closed
security: Added confirmation for sensitive operations#301Ishaan453 wants to merge 1 commit intosteipete:mainfrom
Ishaan453 wants to merge 1 commit intosteipete:mainfrom
Conversation
Owner
|
Superseded by #317, which has now been reviewed, fixuped, and merged to main with the same confirmation-guard intent plus current-main cleanup/tests. Closing this older PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created a new function named confirmSensitive() which does the same work as confirmDestructive() but is named to better reflect operations that are sensitive (security-wise) rather than strictly destructive (data loss).
I applied this new check to the following commands:
gmail delegates add(granting mailbox access)gmail filters create --forward(auto-forwarding emails)drive share --to=anyone(making files public)Fixes #291