fix(ci): harden release workflow against tag script injection#299
Merged
steipete merged 2 commits intosteipete:mainfrom Mar 7, 2026
Merged
Conversation
steipete
force-pushed
the
fix/release-tag-injection-289
branch
from
c6a8bff to
d99df22
Compare
Owner
|
Landed via temp rebase onto main.
Thanks @salmonumbrella! |
klodr
pushed a commit
to klodr/gogcli
that referenced
this pull request
Apr 22, 2026
…te#299) * fix(ci): harden workflow_dispatch tag handling in release * fix(ci): land release workflow hardening note (steipete#299) (thanks @salmonumbrella) --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchtag input against an expected release-tag pattern before useinputs.tagviaenvand quoting it ingit checkoutFixes #289.
Testing
make ci(currently fails on existing unrelated typecheck errors ininternal/cmd/contacts_crud.goon latestmain)