fix: persist refresh interval to UserDefaults on first launch#519
Open
Astro-Han wants to merge 1 commit intosteipete:mainfrom
Open
fix: persist refresh interval to UserDefaults on first launch#519Astro-Han wants to merge 1 commit intosteipete:mainfrom
Astro-Han wants to merge 1 commit intosteipete:mainfrom
Conversation
Write the resolved refreshFrequency value to UserDefaults when the key is absent or contains an unrecognized raw value, matching the pattern used by sessionQuotaNotificationsEnabled and other settings. This ensures the key appears in the plist from the very first run and survives app restarts.
Astro-Han
force-pushed
the
fix/persist-refresh-frequency
branch
from
6fec72b to
383da85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refreshFrequencyvalue to UserDefaults when the key is absent or contains an unrecognized raw value, matching the pattern used bysessionQuotaNotificationsEnabledand other settingsCloses #506
Test plan
swift buildpassesswift test— all SettingsStore tests pass (923 total, 7 pre-existing OAuth/keychain environment failures unrelated to this change)defaults read com.steipete.codexbar | grep refreshFrequencyshows the key