Generalize provider usage bucket groups#512
Open
iam-brain wants to merge 2 commits intosteipete:mainfrom
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 693893f916
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a generic provider-owned bucket-group mechanism for extra live rate-limit sections and uses Codex OAuth Spark data as the first implementation.
The goal is to support provider-specific rate-limit buckets without widening the existing
primary/secondary/tertiarymodel or adding more one-off snapshot fields.Why this approach:
primary/secondary/tertiarymodel intact, so existing menu bar ranking, pace logic, and provider behavior stay stable.What changed:
UsageBucketGroupSnapshotandUsageBucketSnapshottoUsageSnapshotasusageBucketGroups.additional_rate_limitsinto a generic bucket group:codex.sparkGPT-5.3-Codex-Sparkcodex.spark.session,codex.spark.weeklyWhat intentionally did not change:
primary/secondary/tertiarysemantics.Verification
swift testpnpm check./Scripts/compile_and_run.sh