-
-
Notifications
You must be signed in to change notification settings - Fork 24
Optimize LineCollection
#206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize LineCollection
#206
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
==========================================
- Coverage 98.42% 98.41% -0.01%
==========================================
Files 43 43
Lines 1775 1766 -9
Branches 358 357 -1
==========================================
- Hits 1747 1738 -9
Misses 25 25
Partials 3 3
|
stefmolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pulling this out from the other PR, @JCGoran.
Co-authored-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Co-authored-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
stefmolin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworked the distance method to improve naming and cleaned up a few parts.
As requested in #198 (comment), this is now a separate PR.
Describe your changes
LineCollection._distance_point_to_linemethod as it's not used anywhere anymoreLineCollection.distance, resulting in about 100M less function calls for the star shapeLineCollectioninitializer raise aValueErrorif any of the lines is actually a point (i.e.start == end) and add a test for itChecklist