[fix] should hide some symbols that are mostly internal and likely co…#9
Merged
Conversation
…llide with other symbols in linked projects
flynn162
suggested changes
Jun 24, 2025
Contributor
flynn162
left a comment
flynn162
left a comment
There was a problem hiding this comment.
2 more functions do not have any prefix:
invertedVMDmatrixinmpmult.cexpand_message_xmd
Owner
Author
hmmm. right. not sure if this cannot be even static. gotta check this.
hmmm, i think this is needed in libopaque though. maybe prefix it with h2c_ ? |
|
Owner
Author
|
i tested these changes against all my projects that depend on liboprf and they seem to work. although the loss of debug traces is a bit meh. i can live with this. i'll have a last look and merge this over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…llide with other symbols in linked projects
should fix #8