Skip to content

[fix] Install to location other than /usr/local.#20

Merged
stef merged 7 commits into
stef:masterfrom
Dehim1:master
Apr 15, 2026
Merged

[fix] Install to location other than /usr/local.#20
stef merged 7 commits into
stef:masterfrom
Dehim1:master

Conversation

@Dehim1
Copy link
Copy Markdown
Contributor

@Dehim1 Dehim1 commented Mar 28, 2026

I had trouble installing liboprf to a location other than /usr/local.
Uninstall also gave some errors and had weird behavior as it copied files to the installation directory.

This PR fixes these issues.

I also added src/liboprf.so.debug to the .gitignore as this file isn't tracked by the repo.

@stef
Copy link
Copy Markdown
Owner

stef commented Mar 28, 2026

thank you for this. one question, why do you have troubles installing somewhere else than /usr/local when using both DESTDIR and PREFIX env vars?

i note, you use pkgconf before the check if it is available.

Comment thread src/makefile Outdated
@Dehim1 Dehim1 closed this Mar 29, 2026
@Dehim1 Dehim1 reopened this Mar 29, 2026
@sonarqubecloud
Copy link
Copy Markdown

@Dehim1
Copy link
Copy Markdown
Contributor Author

Dehim1 commented Mar 29, 2026

thank you for this. one question, why do you have troubles installing somewhere else than /usr/local when using both DESTDIR and PREFIX env vars?

First the issue was that sodium.h couldn't be found when running make.
Then I got "cannot find -lsodium: No such file or directory"
Then, when running make install, liboprf.pc wasn't updated, so it still had prefix=/usr/local on top.

i note, you use pkgconf before the check if it is available.

Fixed that now.

@stef stef merged commit 5c8c9e6 into stef:master Apr 15, 2026
1 check passed
@stef
Copy link
Copy Markdown
Owner

stef commented Apr 15, 2026

thx for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants