Skip to content

Add real-device mobile CSS override, preserve CSS minification, update package lock and workflow location#5

Open
stebenix wants to merge 2 commits intomainfrom
codex/finalize-repository-setup-for-vite-project-s48j6a
Open

Add real-device mobile CSS override, preserve CSS minification, update package lock and workflow location#5
stebenix wants to merge 2 commits intomainfrom
codex/finalize-repository-setup-for-vite-project-s48j6a

Conversation

@stebenix
Copy link
Copy Markdown
Owner

Motivation

  • Ensure a robust single-column layout and improved header/drawer behavior on real mobile devices (older iOS/Android) without changing desktop/tablet layouts.
  • Preserve specific CSS media queries during build to avoid regressions introduced by aggressive CSS minification.
  • Normalize package registry references and place the deployment workflow in the standard GitHub Actions path.

Description

  • Added a new src/mobile-fix.css with comprehensive real-device mobile overrides and imported it from src/main.js via import './mobile-fix.css';.
  • Extended src/styles.css with additional mobile viewport rules to keep a single-column layout and improved topbar/drawer styles on phones.
  • Updated vite.config.js to set build.cssMinify: false so classic max-width media queries are preserved during build.
  • Added a .gitignore containing common ignores (node_modules/, dist/, .DS_Store, *.log).
  • Moved the deployment workflow file into .github/workflows/deploy.yml and updated package-lock.json to replace internal registry URLs with the public https://registry.npmjs.org/ resolved URLs.

Testing

  • No automated tests were executed as part of this change.

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85c1017072

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/mobile-fix.css
Comment on lines +4 to +5
@media screen and (max-width: 767px),
screen and (hover: none) and (pointer: coarse) and (max-width: 932px) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict the coarse-pointer override to phones

On touch tablets such as an iPad in portrait (~834 CSS px, hover:none/pointer:coarse), this second media query matches even though the viewport is wider than 767px, so every phone-only override in this file runs. That collapses the tablet layout to a single-column .bento and hides topbar actions, whereas the existing tablet breakpoint in src/styles.css keeps several cards in two columns until the narrower phone breakpoint, so real tablets regress despite the stated goal of leaving tablet layouts untouched.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant