feat: add `math/base/special/sincosdf` #9912

bhargava-d16 · 2026-01-26T22:46:43Z

Signed-off-by: Bhargav Dabhade bhargava2005dabhade@gmail.com

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

task: lint_filenames status: passed
task: lint_editorconfig status: passed
task: lint_markdown status: passed
task: lint_package_json status: passed
task: lint_repl_help status: passed
task: lint_javascript_src status: passed
task: lint_javascript_cli status: na
task: lint_javascript_examples status: passed
task: lint_javascript_tests status: passed
task: lint_javascript_benchmarks status: passed
task: lint_python status: na
task: lint_r status: na
task: lint_c_src status: missing_dependencies
task: lint_c_examples status: missing_dependencies
task: lint_c_benchmarks status: missing_dependencies
task: lint_c_tests_fixtures status: na
task: lint_shell status: na
task: lint_typescript_declarations status: passed
task: lint_typescript_tests status: passed
task: lint_license_headers status: passed ---

Resolves None

Description

What is the purpose of this pull request?

This pull request:

Adds complete implementation of math/base/special/sincosdf

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

[] Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

Signed-off-by: Bhargav Dabhade <bhargava2005dabhade@gmail.com> --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

Signed-off-by: Bhargav Dabhade <bhargava2005dabhade@gmail.com> --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2026-01-26T22:53:44Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/sincosdf	$\color{green}251/251$ $\color{green}+0.00%$	$\color{green}7/7$ $\color{green}+0.00%$	$\color{green}3/3$ $\color{green}+0.00%$	$\color{green}251/251$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Planeshifter

Thanks for opening this PR!

Planeshifter · 2026-01-27T05:54:02Z

lib/node_modules/@stdlib/math/base/special/sincosdf/test/test.assign.js

+tape( 'the function computes the sine and cosine (for -256*180.0 < x < 0)', function test( t ) {
+	var cosine;
+	var delta;
+	var sine;
+	var tol;
+	var x;
+	var y;
+	var i;
+	var z;
+
+	z = [ 0.0, 0.0 ];
+	x = mediumNegative.x;
+	sine = mediumNegative.sine;
+	cosine = mediumNegative.cosine;
+
+	for ( i = 0; i < x.length; i++ ) {
+		x[ i ] = f32( x[ i ] );
+		y = sincosdf( x[i], z, 1, 0 );
+		sine[ i ] = f32( sine[ i ] );
+		cosine[ i ] = f32( cosine[ i ] );
+		t.strictEqual( y, z, 'returns output array' );
+		if ( y[0] === sine[ i ] ) {
+			t.strictEqual( y[0], sine[ i ], 'x: '+x[i]+'. Expected: '+sine[i] );
+		} else {
+			delta = absf( y[0] - sine[i] );
+			tol = EPS * absf( sine[i] );
+			t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. Value: '+y[0]+'. Expected: '+sine[i]+'. tol: '+tol+'. delta: '+delta+'.' );
+		}
+		if ( y[1] === cosine[ i ] ) {
+			t.strictEqual( y[1], cosine[ i ], 'x: '+x[i]+'. Expected: '+cosine[i] );
+		} else {
+			delta = absf( y[1] - cosine[i] );
+			tol = 1.01 * EPS * absf( cosine[i] );
+			t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. Value: '+y[1]+'. Expected: '+cosine[i]+'. tol: '+tol+'. delta: '+delta+'.' );
+		}
+	}
+	t.end();
+});


This block (lines 87-124) is an exact duplicate of the test block at lines 48-84 — same description, same mediumNegative fixture data. Looks like a copy-paste leftover. Since mediumPositive is already tested at line 126, this block should just be removed.

Planeshifter · 2026-01-27T05:54:03Z

lib/node_modules/@stdlib/math/base/special/sincosdf/test/test.native.js

+
+var resolve = require( 'path' ).resolve;
+var tape = require( 'tape' );
+var isnanf = require( '@stdlib/math/base/assert/is-nan' );


This imports the double-precision is-nan but names it isnanf. Since this is a single-precision package, let's use the single-precision variant to stay consistent with test.main.js and test.assign.js:

Suggested change

var isnanf = require( '@stdlib/math/base/assert/is-nan' );

var isnanf = require( '@stdlib/math/base/assert/is-nanf' );

Planeshifter · 2026-01-27T05:54:05Z

lib/node_modules/@stdlib/math/base/special/sincosdf/test/test.native.js

+var PINF = require( '@stdlib/constants/float32/pinf' );
+var NINF = require( '@stdlib/constants/float32/ninf' );
+var EPS = require( '@stdlib/constants/float32/eps' );
+var absf = require( '@stdlib/math/base/special/abs' );


Same as above — this imports double-precision abs but the variable is named absf. Let's match the other test files:

Suggested change

var absf = require( '@stdlib/math/base/special/abs' );

var absf = require( '@stdlib/math/base/special/absf' );

Planeshifter · 2026-01-27T05:54:06Z

lib/node_modules/@stdlib/math/base/special/sincosdf/lib/native.js

+*
+* @private
+* @param {number} x - input value (in degrees)
+* @returns {Array<number>} sine and cosine


The return type here should be Float32Array to match what the function actually returns. See the reference sincosf/lib/native.js for the expected pattern:

Suggested change

* @returns {Array<number>} sine and cosine

* @returns {Float32Array} sine and cosine

Planeshifter · 2026-01-27T05:54:06Z

lib/node_modules/@stdlib/math/base/special/sincosdf/docs/types/index.d.ts

+
+interface SinCosdf {
+	/**
+	* Simultaneously computes the sine and cosine of an angle measured in degrees (single-precision).
+	*
+	* @param x - input value (in degrees)
+	* @returns sine and cosine
+	*
+	* @example
+	* var v = sincosdf( 0.0 );
+	* // returns [ ~0.0, ~1.0 ]
+	*
+	* @example
+	* var v = sincosdf( 90.0 );
+	* // returns [ ~1.0, ~0.0 ]
+	*
+	* @example
+	* var v = sincosdf( -30.0 );
+	* // returns [ ~-0.5, ~0.866 ]
+	*
+	* @example
+	* var v = sincosdf( NaN );
+	* // returns [ NaN, NaN ]
+	*/
+	( x: number ): Array<number>;
+
+	/**
+	* Simultaneously computes the sine and cosine of an angle measured in degrees (single-precision) and assigns the results to a provided output array.
+	*
+	* @param x - input value (in degrees)
+	* @param out - output array
+	* @param stride - output array stride
+	* @param offset - output array index offset
+	* @returns sine and cosine
+	*
+	* @example
+	* var Float32Array = require( '@stdlib/array/float32' );
+	*
+	* var out = new Float32Array( 2 );
+	*
+	* var v = sincosdf.assign( 0.0, out, 1, 0 );
+	* // returns <Float32Array>[ ~0.0, ~1.0 ]
+	*
+	* var bool = ( v === out );
+	* // returns true
+	*/
+	assign<T extends ArrayLike<number>>( ...args: [ number, T, number, number ] ): T;


This is missing the NumericArray import and the assign method signature doesn't match the stdlib pattern. Comparing with sincosf/docs/types/index.d.ts, there should be:

An import on line 23: import { NumericArray } from '@stdlib/types/array';

The assign signature should use named parameters with NumericArray:
assign<T extends NumericArray>( x: number, out: T, stride: number, offset: number ): T;

The current spread args style (...args: [ number, T, number, number ]) differs from the established pattern.

@Planeshifter Thank you for the guidance! I’ve followed your instructions and updated the code to use the named-parameters pattern with NumericArray.

After this change, I’m encountering TypeScript linting errors in the test file (lines 70–74), where invalid out arguments (number, boolean, null, object) are expected to be rejected but are not being caught by the type checker.
To double-check, I ran the linter on sincosf, which uses the identical assign(...) signature, and observed the same linting errors there as well.

This makes me think the behavior may be related to how the generic NumericArray constraint is handled by the current TypeScript version, rather than something specific to sincosdf.

Could you please advise how you’d like to proceed here to stay consistent with stdlib patterns?

Planeshifter · 2026-01-27T05:54:07Z

lib/node_modules/@stdlib/math/base/special/sincosdf/lib/index.js

+* @example
+* var sincosdf = require( '@stdlib/math/base/special/sincosdf' );
+*
+* var out = new Float32Array( 2 );


The second @example block uses new Float32Array( 2 ) but doesn't include the Float32Array import. Looking at sincosf/lib/index.js, the second example includes the import:

* var Float32Array = require( '@stdlib/array/float32' ); * var sincosdf = require( '@stdlib/math/base/special/sincosdf' );

Let's add the missing import line so the example is self-contained and runnable.

Signed-off-by: Bhargav Dabhade <bhargava2005dabhade@gmail.com> --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jan 26, 2026

Planeshifter changed the title ~~feat: add math/base/special/sincosdf~~ feat: add math/base/special/sincosdf Jan 27, 2026

Planeshifter requested changes Jan 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add `math/base/special/sincosdf` #9912

feat: add `math/base/special/sincosdf` #9912

bhargava-d16 commented Jan 26, 2026

Uh oh!

stdlib-bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Jan 27, 2026

Uh oh!

Planeshifter Jan 27, 2026

Uh oh!

Planeshifter Jan 27, 2026

Uh oh!

Planeshifter Jan 27, 2026

Uh oh!

Planeshifter Jan 27, 2026

Uh oh!

bhargava-d16 Jan 27, 2026 •

edited

Loading

Uh oh!

Planeshifter Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	var isnanf = require( '@stdlib/math/base/assert/is-nan' );
	var isnanf = require( '@stdlib/math/base/assert/is-nanf' );

	var absf = require( '@stdlib/math/base/special/abs' );
	var absf = require( '@stdlib/math/base/special/absf' );

	* @returns {Array<number>} sine and cosine
	* @returns {Float32Array} sine and cosine

Uh oh!

feat: add math/base/special/sincosdf #9912

Are you sure you want to change the base?

feat: add math/base/special/sincosdf #9912

Conversation

bhargava-d16 commented Jan 26, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

bhargava-d16 Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `math/base/special/sincosdf` #9912

feat: add `math/base/special/sincosdf` #9912

stdlib-bot commented Jan 26, 2026 •

edited

Loading

bhargava-d16 Jan 27, 2026 •

edited

Loading