Skip to content

bench: update random value generation #9891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 7 commits into from
Jan 26, 2026
+411 −358
Merged

bench: update random value generation #9891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dacb5fe
bench: update random value generation
hrshya Jan 25, 2026
5ec66a4
fix: resolve lint issues
hrshya Jan 25, 2026
0423c78
Update benchmark.js
hrshya Jan 25, 2026
53c2648
fix: resolves lint issues
hrshya Jan 25, 2026
b22200e
Update benchmark.js
hrshya Jan 25, 2026
ce8097e
bench: fix description
kgryte Jan 26, 2026
340ba08
Apply suggestions from code review
kgryte Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
var uniform = require( '@stdlib/random/array/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;
var cdf = require( './../lib' );

Expand All @@ -32,20 +33,22 @@

bench( pkg, function benchmark( b ) {
var sigma;
var len;
var opts;
var mu;
var x;
var y;
var i;

len = 100;
x = uniform( len, -100.0, 100.0 );
mu = uniform( len, -50.0, 50.0 );
sigma = uniform( len, EPS, 20.0 + EPS );
opts = {
'dtype': 'float64'
};
x = uniform( 100, -100.0, 100.0, opts );
mu = uniform( 100, -50.0, 50.0, opts );
sigma = uniform( 100, EPS, 20.0 + EPS, opts );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = cdf( x[ i % len ], mu[ i % len ], sigma[ i % len ]);
y = cdf( x[ i % x.length ], mu[ i % mu.length ], sigma[ i % sigma.length ] );

Check warning on line 51 in lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

This line has a length of 85. Maximum allowed is 80
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -58,7 +61,7 @@
b.end();
});

bench( pkg+':factory', function benchmark( b ) {
bench( format( '%s::factory', pkg ), function benchmark( b ) {
var mycdf;
var sigma;
var mu;
Expand All @@ -69,7 +72,9 @@
mu = 0.0;
sigma = 1.5;
mycdf = cdf.factory( mu, sigma );
x = uniform( 100, -3.0, 3.0 );
x = uniform( 100, -3.0, 3.0, {
'dtype': 'float64'
});

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
Expand Down
14 changes: 8 additions & 6 deletions lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,22 @@

bench( pkg, opts, function benchmark( b ) {
var sigma;
var len;
var opts;
var mu;
var x;
var y;
var i;

len = 100;
x = uniform( len, -100.0, 100.0 );
mu = uniform( len, -50.0, 50.0 );
sigma = uniform( len, EPS, 20.0 + EPS );
opts = {
'dtype': 'float64'
};
x = uniform( 100, -100.0, 100.0, opts );
mu = uniform( 100, -50.0, 50.0, opts );
sigma = uniform( 100, EPS, 20.0 + EPS, opts );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = cdf( x[ i % len ], mu[ i % len ], sigma[ i % len ]);
y = cdf( x[ i % x.length ], mu[ i % mu.length ], sigma[ i % sigma.length ] );

Check warning on line 59 in lib/node_modules/@stdlib/stats/base/dists/normal/cdf/benchmark/benchmark.native.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

This line has a length of 85. Maximum allowed is 80
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
Loading