Skip to content

bench: refactor to use string interpolation in tools/snippets/benchmark #9890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SuYaSh-PaThAk04 wants to merge 1 commit into from
+4 −2
Closed

bench: refactor to use string interpolation in tools/snippets/benchmark #9890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/snippets/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
var resolve = require( 'path' ).resolve;
var bench = require( '@stdlib/bench' );
var tryRequire = require( '@stdlib/utils/try-require' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;


Expand All @@ -36,17 +37,17 @@

// MAIN //

bench( pkg+'::native', opts, function benchmark( b ) {
bench( format( '%s::native', pkg ), opts, function benchmark( b ) {
var i;
b.tic();
for ( i = 0; i < b.iterations; i++ ) {
// TODO: synchronous task

Check warning on line 44 in tools/snippets/benchmark/benchmark.native.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: synchronous task'
if ( TODO/* TODO: condition */ ) {

Check warning on line 45 in tools/snippets/benchmark/benchmark.native.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: condition'
b.fail( 'something went wrong' );
}
}
b.toc();
if ( TODO/* TODO: condition */ ) {

Check warning on line 50 in tools/snippets/benchmark/benchmark.native.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: condition'
b.fail( 'something went wrong' );
}
b.pass( 'benchmark finished' );
Expand Down
3 changes: 2 additions & 1 deletion tools/snippets/benchmark/benchmark.wasm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@

var bench = require( '@stdlib/bench' );
var hasWebAssemblySupport = require( '@stdlib/assert/has-wasm-support' );
var format = require( '@stdlib/string/format' );
var pkg = require( './../package.json' ).name;
var TODO = require( './../lib/wasm.js' );

Check failure on line 27 in tools/snippets/benchmark/benchmark.wasm.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

cannot resolve module: "/home/runner/work/stdlib/stdlib/tools/snippets/lib/wasm.js"


// VARIABLES //
Expand All @@ -35,17 +36,17 @@

// MAIN //

bench( pkg+'::wasm', opts, function benchmark( b ) {
bench( format( '%s::wasm', pkg ), opts, function benchmark( b ) {
var i;
b.tic();
for ( i = 0; i < b.iterations; i++ ) {
// TODO: synchronous task

Check warning on line 43 in tools/snippets/benchmark/benchmark.wasm.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: synchronous task'
if ( TODO/* TODO: condition */ ) {

Check warning on line 44 in tools/snippets/benchmark/benchmark.wasm.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: condition'
b.fail( 'something went wrong' );
}
}
b.toc();
if ( TODO/* TODO: condition */ ) {

Check warning on line 49 in tools/snippets/benchmark/benchmark.wasm.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Unexpected 'todo' comment: 'TODO: condition'
b.fail( 'something went wrong' );
}
b.pass( 'benchmark finished' );
Expand Down
Loading