Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/fs/read-wasm/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
* var join = require( 'path' ).join;
* var readWASM = require( '@stdlib/fs/read-wasm' );
*
* var fpath = join( __dirname, 'foo.wasm' );
* var fpath = join( __dirname, 'example.wasm' );
* readWASM( fpath, onRead );

Check warning on line 31 in lib/node_modules/@stdlib/fs/read-wasm/lib/index.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files

Unknown word: "fpath"
*
* function onRead( error, buf ) {
* if ( error ) {
Expand All @@ -42,8 +42,8 @@
* var instanceOf = require( '@stdlib/assert/instance-of' );
* var readWASMSync = require( '@stdlib/fs/read-wasm' ).sync;
*
* var fpath = join( __dirname, 'foo.wasm' );
* var fpath = join( __dirname, 'example.wasm' );
* var out = readWASMSync( fpath );

Check warning on line 46 in lib/node_modules/@stdlib/fs/read-wasm/lib/index.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files

Unknown word: "fpath"
* if ( instanceOf( out, Error ) ) {
* throw out;
* }
Expand Down
24 changes: 12 additions & 12 deletions lib/node_modules/@stdlib/utils/async/inmap/benchmark/benchmark.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ bench( pkg, function benchmark( b ) {
clbk( null, v*i );
}
}
arr = new Array( 100 );
len = arr.length;
for ( i = 0; i < len; i++ ) {
arr[ i ] = EPS;
arr = [];
for ( i = 0; i < 100; i++ ) {
arr.push( EPS );
}
len = arr.length;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please double-check this change?we’re initializing the array iteratively—just want to ensure the length handling is correct and intentional here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya checked

i = 0;
b.tic();

Expand Down Expand Up @@ -79,11 +79,11 @@ bench( pkg+':series=true', function benchmark( b ) {
opts = {
'series': true
};
arr = new Array( 100 );
len = arr.length;
for ( i = 0; i < len; i++ ) {
arr[ i ] = EPS;
arr = [];
for ( i = 0; i < 100; i++ ) {
arr.push( EPS );
}
len = arr.length;
i = 0;
b.tic();

Expand Down Expand Up @@ -119,11 +119,11 @@ bench( pkg+':limit=3', function benchmark( b ) {
opts = {
'limit': 3
};
arr = new Array( 100 );
len = arr.length;
for ( i = 0; i < len; i++ ) {
arr[ i ] = EPS;
arr = [];
for ( i = 0; i < 100; i++ ) {
arr.push( EPS );
}
len = arr.length;
i = 0;
b.tic();

Expand Down
Loading