refactor: add typed array support in DSV parser #9817
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Contributor
Author
|
cc @kgryte |
kgryte
reviewed
Jan 26, 2026
| setReadOnly( Parser.prototype, '_setField', function set( value, idx ) { | ||
| var buf = this._rowBuffer; | ||
|
|
||
| // FIXME: as buffer may be provided from userland, use `set` accessor and consider using `@stdlib/utils/push` to allow support of dynamically resizing fixed length buffers |
Member
There was a problem hiding this comment.
This comment should not be removed, as the proposed changes only partially resolve what is described.
Member
There was a problem hiding this comment.
It is also not clear whether we want to use utils/push here. The reason why this was not done originally was due to performance concerns. As such, I am not convinced that this PR should move forward.
Contributor
Author
There was a problem hiding this comment.
i mean the performance concern make sense it is low i mean should we go with caching the buffer type at initialization and using a fast path for arrays?
what u think on it ?
kgryte
changed the title
kgryte
added
Needs Discussion
Restore the FIXME comment as requested by reviewer. The comment notes that while @stdlib/utils/push is now used to support TypedArrays, the set accessor for _rowBuffer still needs to be implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
Fixes a crash in
@stdlib/utils/dsv/base/parsewhen a TypedArray is provided as therowBufferoption. The_setFieldmethod was callingbuf.push()which throws a TypeError since TypedArrays do not have apushmethod. added the fix suggested in the existing FIXME comment by using@stdlib/utils/push, which supports arrays, typed arrays, and array-like objects.Related Issues
This pull request has the following related issues:
Questions
No.
Checklist
AI Assistance
@stdlib-js/reviewers