fix(remark): move HTML section linters and skip YAML frontmatter#11042
Open
batpigandme wants to merge 1 commit intostdlib-js:developfrom
Open
fix(remark): move HTML section linters and skip YAML frontmatter#11042batpigandme wants to merge 1 commit intostdlib-js:developfrom
batpigandme wants to merge 1 commit intostdlib-js:developfrom
Conversation
Move HTML section linting plugins to the central linting plugin list to ensure consistent configuration and update the expected sections linter to ignore YAML frontmatter when searching for anchor nodes.
Assisted-by: Claude-Opus-4-6
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move HTML section linting plugins to the central linting plugin list to ensure consistent configuration and update the expected sections linter to ignore YAML frontmatter when searching for anchor nodes so that
<-- lint disable ... -->comments work properly withremark-lintandunified-message-control.Assisted-by: Claude-Opus-4-6
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Description
This pull request:
Extends #11009 to make the lint disabling less brittle, and compatible with the use of YAML frontmatter (discovered that it wasn't when trying to use a GitHub Agentic Workflow, the structure of which is YAML and Markdown).
AI Description
etc/remark/plugins/lint/index.js— Movedlint-expected-html-sectionsandlint-html-section-structureinto the lint plugin batch so their transforms run beforeremark-message-control's one-shot message filter. This is the core fix that makes<!-- lint disable expected-html-sections -->work.lib/node_modules/@stdlib/_tools/remark/plugins/remark-lint-expected-html-sections/lib/linter.js— UpdatedgetAnchorNodeto skipyamlfrontmatter nodes, so messages in files with YAML frontmatter aren't anchored before disable comments.Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Used Claude Opus 4.6 to troubleshoot failing disabling of linter. Full session here: https://app.warp.dev/conversation/b9bc28f8-92dc-45a6-b94f-825c576ed398
@stdlib-js/reviewers