Conversation
Contributor
pratzl
commented
Mar 17, 2026
pratzl
commented
- Reorder all spec blocks to: Mandates → Preconditions → Hardened preconditions → Effects → Postconditions → Returns → Throws → Complexity → Remarks
- Add missing Mandates sections for all algorithms with concept constraints (BFS, DFS, Topological Sort, Dijkstra, Bellman-Ford, find_negative_cycle, connected_components, afforest, kosaraju, MIS, Jaccard, Kruskal, inplace_kruskal, Prim)
- Add Constant When for constexpr functions (Dijkstra, Bellman-Ford)
- Add Postconditions for Dijkstra and Bellman-Ford (distances/predecessors)
- Add Throws sections for BFS, DFS, Dijkstra, Bellman-Ford
- Add [[nodiscard]] annotations to Returns (Bellman-Ford, Topological Sort, triangle_count, directed_triangle_count)
- Add noexcept documentation for triangle_count, directed_triangle_count
- Fix BFS visitor events: remove incorrect on_edge_relaxed/not_relaxed
- Move compile-time concept constraints from Hardened preconditions to Mandates (inplace_kruskal permutable, Prim basic_edge_weight_function)
- Define \constantwhen macro in P1709-preamble.tex
- Reorder all spec blocks to: Mandates → Preconditions → Hardened preconditions → Effects → Postconditions → Returns → Throws → Complexity → Remarks - Add missing Mandates sections for all algorithms with concept constraints (BFS, DFS, Topological Sort, Dijkstra, Bellman-Ford, find_negative_cycle, connected_components, afforest, kosaraju, MIS, Jaccard, Kruskal, inplace_kruskal, Prim) - Add Constant When for constexpr functions (Dijkstra, Bellman-Ford) - Add Postconditions for Dijkstra and Bellman-Ford (distances/predecessors) - Add Throws sections for BFS, DFS, Dijkstra, Bellman-Ford - Add [[nodiscard]] annotations to Returns (Bellman-Ford, Topological Sort, triangle_count, directed_triangle_count) - Add noexcept documentation for triangle_count, directed_triangle_count - Fix BFS visitor events: remove incorrect on_edge_relaxed/not_relaxed - Move compile-time concept constraints from Hardened preconditions to Mandates (inplace_kruskal permutable, Prim basic_edge_weight_function) - Define \constantwhen macro in P1709-preamble.tex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.