[6.x] Extract form submission logic into SubmitForm action#14375
Open
duncanmcclean wants to merge 8 commits into6.xfrom
Open
[6.x] Extract form submission logic into SubmitForm action#14375duncanmcclean wants to merge 8 commits into6.xfrom
SubmitForm action#14375duncanmcclean wants to merge 8 commits into6.xfrom
Conversation
SubmitForm actionSubmitForm action
jasonvarga
requested changes
Mar 27, 2026
Member
jasonvarga
left a comment
There was a problem hiding this comment.
We should make the action class injectable and you call submit on it, instead of invoking it.
The submit method should also perform validation. Otherwise it'd be very easy to forget to validate and pass in raw request values.
The validator could still be exposed from that class if you wanted to separately validate, like in a livewire component.
The FrontendFormRequest could be cleaned up to avoid validation, since the action would be doing it. And actually our controller seems to already handle ValidationExceptions (thrown by events) but it could catch the one thrown by submit too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request extracts the form submission logic from Statamic's
FormControllerinto a reusableSubmitFormaction class, allowing third-party developers to use it in Livewire components or custom API endpoints.Usage
Closes statamic/ideas#1409