[6.x] Filters can only be removed by clicking cross#14220
Merged
jasonvarga merged 10 commits into6.xfrom Mar 27, 2026
Merged
Conversation
For screen reader users, a row of identical Clear buttons is ambiguous because it doesn’t say which filter will be removed. This makes the label contextual, like Clear filter {{ badge }} or Remove {{ badge.field }}
Leverage the filled Button variant for badge styling instead of duplicating Tailwind classes, now that Button merges external class attrs through twMerge. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jasonvarga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
Currently, it's very easy to accidentally delete filters since they have
cursor: pointeron the whole button target.I have previously clicked on a filter, thinking it will open it up for modification, only for the filter to be deleted unintentionally.
What this PR Does
Splits saved filter buttons into two parts, separating the "x" into a separate intentional control so that clicking a filter doesn't accidentally delete it.
Before
Clicking anywhere on the saved filter deletes the filter
After
Only clicking the
xleads to deletionHow to Reproduce