[6.x] Fix adding Bard sets #13669
Open
[6.x] Fix adding Bard sets #13669
+45
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think this is not fixing all the issues with sets. When you have a replicator with a nested Bard (using sets), even with this change this would throw the other error mentioned in the issue. |
When the parent set is a replicator set, we need to get `.type` instead of `.attrs.value.type`.
Member
Author
Whoops, I missed that part of the issue. Looking into it now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes various issues adding Bard/Replicator sets after #13427.
indexargument is only passed in the Replicator fieldtype.Fixes #13665