[6.x] Fix passkeys differently #13666
Merged
+38
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2162e04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #13566
Fixes #13561 differently.
When someone has
"minimum-stability": "dev", they would've had the unreleased5.3version ofwebauth-libinstalled, which had a breaking change.In #13566 I decided to optimistically code as if 5.3 would be available by the time we want to release v6. That doesn't look likely.
This PR reverts #13566 because the webauth-lib will now be backwards compatible as per web-auth/webauthn-framework#804. This results in no changes on our end.
This PR also changes the constraint from
^5.2to~5.2.0so that 5.3 cannot be installed for people that still have their minimum stability set to dev.When the mentioned PR is merged and 5.3 is released, we can switch the constraint back.