[5.x] Avoid updating Bard value unless content has actually changed #13645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Bard Fieldtype would emit an update even if the content is exactly the same as the current value.
This causes problems when localizing entries. When a localization is created, we make a request to the server to get the form's values. This subsequently leads to Bard's
valueprop being updated.However, because the object reference has changed, the check in the
jsonwatcher considers the value to be different, which ultimately leads to thelocalizedFieldsarray being incorrectly updated.This PR fixes it by stringifying the two objects so we can compare contents, and not references.