Skip to content

[6.x] Improve Combobox performance #13625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 6 commits into from
Jan 23, 2026
+16 −11
Merged

[6.x] Improve Combobox performance #13625

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8587ea
No need to deep clone here.
duncanmcclean Jan 21, 2026
61bc80b
Use `filteredOptions` length to determin min-height, not `options`
duncanmcclean Jan 21, 2026
d4b8e0e
Use `.some()` instead of `.filter()` to avoid unnecessary comparisons
duncanmcclean Jan 21, 2026
e57abd2
Only measure option widths for three of the options with the longest …
duncanmcclean Jan 21, 2026
50e0952
Force mount content when there's lots of options
duncanmcclean Jan 21, 2026
f7617c6
wip
duncanmcclean Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions resources/js/components/ui/Combobox/Combobox.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ const selectedOption = computed(() => {

const getOptionLabel = (option) => option?.[props.optionLabel];
const getOptionValue = (option) => option?.[props.optionValue];
const isSelected = (option) => selectedOptions.value.filter((item) => getOptionValue(item) === getOptionValue(option)).length > 0;
const isSelected = (option) => selectedOptions.value.some((item) => getOptionValue(item) === getOptionValue(option));

const isOptionDisabled = (option) => {
if (isSelected(option)) return false;
Expand Down Expand Up @@ -196,10 +196,8 @@ const filteredOptions = computed(() => {
return props.options;
}

const options = JSON.parse(JSON.stringify(props.options));

const results = fuzzysort
.go(searchQuery.value, options, {
.go(searchQuery.value, props.options, {
all: true,
key: props.optionLabel,
})
Expand Down Expand Up @@ -253,6 +251,12 @@ function updateDropdownOpen(open) {
function measureOptionWidths() {
if (!filteredOptions.value || filteredOptions.value.length === 0) return;

// Find the options with the longest labels by character count.
// We only measure these candidates rather than all options for performance.
const candidates = [...filteredOptions.value]
.sort((a, b) => (getOptionLabel(b)?.length || 0) - (getOptionLabel(a)?.length || 0))
.slice(0, 5);

let maxWidth = 0;
const measurementCanvas = document.createElement('canvas');
const context = measurementCanvas.getContext('2d');
Expand All @@ -261,8 +265,7 @@ function measureOptionWidths() {
// This matches the itemClasses styling
context.font = '14px -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif';

// Measure all options to find the widest
filteredOptions.value.forEach(option => {
candidates.forEach(option => {
const label = getOptionLabel(option);
const metrics = context.measureText(label);
const textWidth = metrics.width;
Expand Down Expand Up @@ -418,11 +421,13 @@ defineExpose({

<ComboboxPortal>
<ComboboxContent
:force-mount="true"
:hidden="!dropdownOpen"
position="popper"
:side-offset="5"
align="start"
:class="[
'shadow-ui-sm z-(--z-index-above) rounded-lg border border-gray-200 bg-white p-2 dark:border-white/10 dark:bg-gray-800',
'shadow-ui-sm z-(-well-z-index-above) rounded-lg border border-gray-200 bg-white p-2 dark:border-white/10 dark:bg-gray-800',
'max-h-[var(--reka-combobox-content-available-height)] min-w-[var(--reka-combobox-trigger-width)]',
'overflow-hidden'
]"
Expand All @@ -444,10 +449,10 @@ defineExpose({
ref="viewport"
class="max-h-[calc(var(--reka-combobox-content-available-height)-2rem)] overflow-y-scroll"
:class="{
'min-h-[2.25px]': options.length === 0,
'min-h-[2.5rem]': options.length === 1,
'min-h-[5rem]': options.length === 2,
'min-h-[7.5rem]': options.length >= 3,
'min-h-[2.25px]': filteredOptions.length === 0,
'min-h-[2.5rem]': filteredOptions.length === 1,
'min-h-[5rem]': filteredOptions.length === 2,
'min-h-[7.5rem]': filteredOptions.length >= 3,
'pr-3': scrollbarRef?.isVisible,
}"
data-ui-combobox-viewport
Expand Down