Skip to content

starknet_os: rename generic SHA names to SHA256#14205

Open
dorimedini-starkware wants to merge 1 commit into
05-17-blockifier_sha512_syscallfrom
05-26-starknet_os_rename_generic_sha_names_to_sha256
Open

starknet_os: rename generic SHA names to SHA256#14205
dorimedini-starkware wants to merge 1 commit into
05-17-blockifier_sha512_syscallfrom
05-26-starknet_os_rename_generic_sha_names_to_sha256

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 26, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 26, 2026

PR Summary

Low Risk
Refactor-only renames and shared syscall structs; execution and padding logic are unchanged.

Overview
This PR renames and deduplicates SHA-related symbols so SHA-256 is explicit in the OS and syscall VM layer, while SHA-512 keeps its own names.

In blockifier, separate Sha256ProcessBlock* and Sha512ProcessBlock* request/response types are replaced by shared ShaProcessBlockRequest / ShaProcessBlockResponse (same layout for both sha256_process_block and sha512_process_block); behavior is unchanged.

In starknet_os, generic Sha2 names become Sha256: hint Sha2FinalizeSha256Finalize, sha2_finalizesha256_finalize, SHA2_FINALIZESHA256_FINALIZE, calculate_paddingcalculate_sha256_padding, and const id ShaBatchSizeSha256BatchSize. The Blake2s IV used for SHA-256 padding is imported as SHA256_IV. Hint-coverage fixtures are updated to Sha256Finalize.

Risk: Low — naming and type consolidation only; no new crypto or syscall semantics.

Reviewed by Cursor Bugbot for commit 0827a82. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch from 7c3aaf4 to 7ab7958 Compare May 26, 2026 13:19
@dorimedini-starkware dorimedini-starkware force-pushed the 05-17-blockifier_sha512_syscall branch from 0094ede to d198e92 Compare May 26, 2026 13:36
@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch from 7ab7958 to 83d42bb Compare May 26, 2026 13:36
@dorimedini-starkware dorimedini-starkware force-pushed the 05-17-blockifier_sha512_syscall branch from d198e92 to d16a453 Compare May 26, 2026 14:16
@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch 2 times, most recently from 3917b8c to add280f Compare May 26, 2026 14:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-17-blockifier_sha512_syscall branch from d16a453 to 014f2e5 Compare May 26, 2026 14:47
@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch from add280f to 0118f50 Compare May 26, 2026 14:47
@dorimedini-starkware dorimedini-starkware force-pushed the 05-17-blockifier_sha512_syscall branch from 014f2e5 to bea1354 Compare May 26, 2026 16:01
@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch from 0118f50 to 26356e4 Compare May 26, 2026 16:01
@dorimedini-starkware dorimedini-starkware force-pushed the 05-17-blockifier_sha512_syscall branch from bea1354 to 8936907 Compare May 26, 2026 16:11
@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch from 26356e4 to 3d201f0 Compare May 26, 2026 16:11
@dorimedini-starkware dorimedini-starkware force-pushed the 05-17-blockifier_sha512_syscall branch from 8936907 to d2c4983 Compare May 26, 2026 16:27
@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch 2 times, most recently from 86f6097 to b70ac40 Compare May 26, 2026 16:33
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 26, 2026

@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch from b70ac40 to 78a6012 Compare May 26, 2026 16:42
@dorimedini-starkware dorimedini-starkware force-pushed the 05-17-blockifier_sha512_syscall branch 2 times, most recently from 3b71060 to 94e61a4 Compare May 26, 2026 16:46
@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch from 78a6012 to 78e409f Compare May 26, 2026 16:46
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-17-blockifier_sha512_syscall branch from 94e61a4 to 7dd2592 Compare May 26, 2026 18:00
@dorimedini-starkware dorimedini-starkware force-pushed the 05-26-starknet_os_rename_generic_sha_names_to_sha256 branch from 78e409f to 0827a82 Compare May 26, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants