apollo_node_config: batcher support for validation only node config.

[asaf-sw]

No description provided.

[reviewable-StarkWare]

This change is 

[asaf-sw]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_node_config: batcher support for validation only node config. #13625 👈 (View in Graphite)
• apollo_node_config: introduce validation only node config. #13557
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guy-starkware]

@guy-starkware reviewed 4 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on asaf-sw).

[guy-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on asaf-sw).

[ShahakShama]

@ShahakShama reviewed 1 file and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on asaf-sw).

---

a discussion (no related file):
Let's discuss this here: Why do you need the validation_only flag in batcher and not just use mempool client's optionness

---

crates/apollo_batcher/src/batcher.rs line 226 at r2 (raw file):

            "validation_only={} but mempool_client is {}",
            config.static_config.validation_only,
            if mempool_client.is_none() { "None" } else { "Some" }

Consider mempool_client.map(|_| "...") instead

---

crates/apollo_node/src/components.rs line 89 at r2 (raw file):

                .get_committer_shared_client()
                .expect("Committer client should be available");
            let mempool_client = if config.validation_only {

Use bool::then

[ShahakShama]

Unblocking for the holiday as these comments aren't critical. Please fix them in a future PR

@ShahakShama made 1 comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on asaf-sw).

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[asaf-sw]

@asaf-sw resolved 1 discussion.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on asaf-sw).

[asaf-sw]

@asaf-sw resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on asaf-sw).

[asaf-sw]

@asaf-sw made 1 comment and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on asaf-sw).

[asaf-sw]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

​This is intentional that code should not be reachable when the node is in Validation Only mode and if we somehow reached it it's an internal logic bug.