apollo_integration_tests: add fake cende and feeder server#13623
Open
guy-starkware wants to merge 1 commit intomainfrom
Open
apollo_integration_tests: add fake cende and feeder server#13623guy-starkware wants to merge 1 commit intomainfrom
guy-starkware wants to merge 1 commit intomainfrom
Conversation
|
This change is |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bffb636fb9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
crates/apollo_integration_tests/src/fake_starknet_server_test.rs
Outdated
Show resolved
Hide resolved
guy-starkware
force-pushed
the
guyn/cende/fake_server
branch
3 times, most recently
from
db6482b to
0e18fb8
Compare
crates/apollo_integration_tests/src/fake_starknet_server_test.rs
Outdated
Show resolved
Hide resolved
guy-starkware
force-pushed
the
guyn/cende/fake_server
branch
2 times, most recently
from
02c0b1c to
c08373e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
guy-starkware
force-pushed
the
guyn/cende/fake_server
branch
from
c08373e to
3086d47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Mostly adds test-only infrastructure plus widespread
Cargo.tomlreordering/lint metadata tweaks; low functional risk outside of integration-test behavior and build metadata.Overview
Introduces
FakeStarknetServerinapollo_integration_tests, an axum-based in-process server that emulates key Feeder Gateway and Cende recorder endpoints, with a shared mutable state for seeding responses and inspecting written blobs.Adds comprehensive tests for the fake server’s routing and error behavior, and wires the module into the crate (
lib.rs) with the neededreqwestdev dependency. Separately, many crates’Cargo.tomlfiles are reorganized (moving[lints],[features],[build-dependencies], andcargo-machetemetadata blocks) without intended runtime logic changes.Written by Cursor Bugbot for commit 3086d47. This will update automatically on new commits. Configure here.