echonet: rename replay functions before getting block metadata#13622
Open
ayeletstarkware wants to merge 1 commit intomainfrom
Open
echonet: rename replay functions before getting block metadata#13622ayeletstarkware wants to merge 1 commit intomainfrom
ayeletstarkware wants to merge 1 commit intomainfrom
Conversation
|
This change is |
ayeletstarkware
force-pushed
the
ayelet/fifo/block-metadata/rename-functions
branch
from
62c7d7d to
870af15
Compare
ayeletstarkware
force-pushed
the
ayelet/fifo/block-metadata/rename-functions
branch
from
870af15 to
b39b80a
Compare
ayeletstarkware
force-pushed
the
ayelet/fifo/block-metadata/rename-functions
branch
from
b39b80a to
aa33f60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches cross-component RPC enums and mempool FIFO sequencing state; a mismatch in request variants or metadata defaults could break Echonet proposal building or transaction gating.
Overview
Replaces the
get_batch_timestamp/resolve_batch_timestamprequest/response flow withget_block_metadata/resolve_block_metadata, returning a newReplayMetadata { timestamp, block_number }type end-to-end (mempool ↔ batcher ↔ consensus orchestrator).Updates FIFO mempool gating to resolve proposal metadata (timestamp + expected block number) via
TransactionQueueTrait::resolve_metadata, with fee-priority mode explicitly returningblock_number=None. Renames the Echonet override flag in proposal building from timestamp-only to metadata-wide, and updates Grafana dashboard panels/metrics labels accordingly.Written by Cursor Bugbot for commit aa33f60. This will update automatically on new commits. Configure here.