Skip to content

Fix lexical and rerank feature is disabled first, then enabled backward compatibility #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hazel-Datastax wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fix lexical and rerank feature is disabled first, then enabled backward compatibility #2463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b025ad1
fix and testes
Hazel-Datastax May 5, 2026
5fd7368
refactor
Hazel-Datastax May 5, 2026
a2a0527
formate
Hazel-Datastax May 5, 2026
57f2931
fix
Hazel-Datastax May 5, 2026
ab1cbdc
fix dse it
Hazel-Datastax May 7, 2026
38a014b
Merge branch 'main' into hazel/fix-lexical-rerank-disable-then-enable…
Hazel-Datastax May 7, 2026
e6f317a
fix the string
Hazel-Datastax May 7, 2026
303b8b8
change to 2 methods
Hazel-Datastax May 7, 2026
59bcd72
refactor
Hazel-Datastax May 7, 2026
a169874
Merge branch 'main' into hazel/fix-lexical-rerank-disable-then-enable…
Hazel-Datastax May 8, 2026
d1d0875
refactor
Hazel-Datastax May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...ava/io/stargate/sgv2/jsonapi/service/operation/collections/CreateCollectionOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,10 +207,11 @@ public Uni<Supplier<CommandResult>> execute(
// In addition, we need to check that new lexical settings are for defaults
// (difficult to check the same for reranking; for now assume that if lexical
// is default, reranking is also default).
if (oldLexical == CollectionLexicalConfig.configForPreLexical()
&& newLexical == CollectionLexicalConfig.configForDefault()
&& oldReranking == CollectionRerankDef.configForPreRerankingCollection()
&& newReranking == CollectionRerankDef.configForDefault()) {
if (Objects.equals(oldLexical, CollectionLexicalConfig.configForPreLexical())
&& Objects.equals(newLexical, CollectionLexicalConfig.configForDefault())
&& Objects.equals(
oldReranking, CollectionRerankDef.configForPreRerankingCollection())
&& Objects.equals(newReranking, CollectionRerankDef.configForDefault())) {
var originalNewSettings = newCollectionSettings;
newCollectionSettings =
newCollectionSettings.withLexicalAndRerankOverrides(
Expand Down
Loading
Loading