Debug_data_generation fixes #1128
Conversation
WardBrian
left a comment
WardBrian
left a comment
There was a problem hiding this comment.
A few comments. This looks great overall
src/middle/Expr.ml
Outdated
| ( StanLib (transpose, FnPlain, _) | ||
| , [{pattern= FunApp (CompilerInternal FnMakeRowVec, l); _}] ) | ||
| when String.equal transpose (Operator.to_string Transpose) -> |
There was a problem hiding this comment.
[Optional] - I think it is easier to read if the pattern is StanLib ("Transpose__", .... rather than a guard clause here, but it is relying on how Operators are currently translated which I suppose could change
There was a problem hiding this comment.
Yeah, I could go either way. CompilerInternal got this one right but I guess operators gotta be StanLib.
|
@serban-nicusor-toptal any idea why the compilation CI didn’t run on this most recent set of changes? |
|
It only runs when there are changes to |
|
I thought we ran it on changes to test/integration/good and src/? I suppose it would be difficult to make a breaking change without touching the output of the dune tests |
|
At some point we separated them I think to speed up CI times tho if needed we can always change it. |
3 participants
After #1115
Debug_data_generation.mllives inanalysis_and_optimizationinstead offrontendand it should no longer useFrontend.Ast. This PR removes Ast from data generation.Also, generation of matrices with non-scalar lower/upper bounds was broken; I fixed that too.
Submission Checklist
Copyright and Licensing
Copyright holder: Niko Huurre
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)