-
-
Notifications
You must be signed in to change notification settings - Fork 48
Add DAE signature support #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do you have any sense of a timeline on stan-dev/math#2644? #1027 is nearing completion, and whichever one of these merges first will create problems for the other (the typechecking and code gen of variadic functions is more or less completely rewritten in #1027) |
From the initial feedback from @charlesm93 it should be soon. Of course the final decision is his. |
WardBrian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, otherwise LGTM
WardBrian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these comments in Stan_math_signatures provide more clutter than illumination.
Other than that, LGTM. I will approve/merge when the stan::math PR is merged and docs are approved
|
Looks like you'll need to update to the new pattern introduced in #1004 - should be pretty easy to see based on the variadic ode, again |
WardBrian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to go after the math branch is merged
|
Tests pass so feel free to merge. |
|
Doc is under review still, but I think it will definitely get in before the release so we can merge |
This PR addresses #1091.
new integration tests:
Submission Checklist
Release notes
Support Differential-Algebraic Equation solver.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)