Add "file://" protocol to stan_progress.html#905
Open
JHonaker wants to merge 1 commit intostan-dev:developfrom
Open
Add "file://" protocol to stan_progress.html#905JHonaker wants to merge 1 commit intostan-dev:developfrom
JHonaker wants to merge 1 commit intostan-dev:developfrom
Conversation
Adding the "file://" protocol to the beginning of the iframe increases compatibility with other browsers. Before, the update page would work in R Studio (which is why I think it hasn't been fixed so far) and using Edge/IE. Firefox complained about an invalid protocol, and would not display the page. After this simple change, it works as expected, and eliminates the need for "open_progress = FALSE" when using something else, like Emacs and ESS.
Contributor
|
This sounds good. I'll test it on Linux. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adding the "file://" protocol to the beginning of the iframe increases compatibility with other browsers. Before, the update page would work in R Studio (which is why I think it hasn't been fixed so far) and using Edge/IE. Firefox complained about an invalid protocol, and would not display the page. After this simple change, it works as expected, and eliminates the need for "open_progress = FALSE" when using something else, like Emacs and ESS.
Intended Effect:
Increase compatibility of stan_progress.html with more browsers.
How to Verify:
Run a Stan model outside of R Studio with a non-Edge/IE default browser or open the HTML file created in the Temp directory.
Side Effects:
None
Documentation:
None needed.
Reviewer Suggestions:
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: