Skip to content

Update workflows#398

Draft
TeemuSailynoja wants to merge 2 commits intostan-dev:masterfrom
TeemuSailynoja:update-workflows
Draft

Update workflows#398
TeemuSailynoja wants to merge 2 commits intostan-dev:masterfrom
TeemuSailynoja:update-workflows

Conversation

@TeemuSailynoja
Copy link
Contributor

Summary

This should fix two of the failing workflow checks.

In short, touchstone-receive.yaml and touchstone-comment.yaml use an outdated action specified in lorenzwalthert/touchstone/actions/comment@v1. Although there is no new version release, the repo has been updated and the checks pass with the latest commit ID.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

@TeemuSailynoja
Copy link
Contributor Author

The last two seem to be failing because of missing system packages.

@paul-buerkner
Copy link
Collaborator

Thanks! Do the last two fail because of some pandoc package not being available? If so, I had the same issue in brms and fixed it by fixing the ubuntu version (https://github.com/paul-buerkner/brms/blob/master/.github/workflows/R-CMD-check.yaml). Do you think it could help here too? Not sure what to do with the mac one though.

@TeemuSailynoja
Copy link
Contributor Author

Missing system packages:
Ubuntu - curl (available for Ubuntu from libcurl4-openssl-dev)
macOS is missing the file libintl.h, which apparently comes with brew install gettext

@TeemuSailynoja
Copy link
Contributor Author

The ubuntu-latest is trying to run the tests on Ubuntu 24.04.2. I would expect fixing the version to Ubuntu 22.04 to do the trick. The workflow file is actually calling
remotes::system_requirements("ubuntu", "18.04") here. remotes does not seem to include 24.04 yet.

@TeemuSailynoja
Copy link
Contributor Author

For some reason, the workflow file for touchstone comment from the master branch is being used instead of the updated one in the PR. Atleast that is what I see when I inspect the run: https://github.com/stan-dev/posterior/actions/runs/13966245808

@paul-buerkner
Copy link
Collaborator

@TeemuSailynoja what is the status of this PR?

@paul-buerkner paul-buerkner added this to the posterior 1.7.0 milestone Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants