Skip to content

Conversation

@WardBrian
Copy link
Member

@WardBrian WardBrian commented Nov 18, 2021

Submission Checklist

  • Builds locally
  • New functions marked with `r since("VERSION")`
  • Declare copyright holder and open-source license: see below

Summary

Update deprecation sections to reflect stan-dev/design-docs#43

Related to stan-dev/stanc3#1044

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks---just a few minor comments.

Copy link
Member

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bob-carpenter
Copy link
Member

It's still marked as draft, but if your intention is to merge, you should be able to do that now.

@WardBrian
Copy link
Member Author

@bob-carpenter I'm going to see if any further documentation needs come up in the next couple stanc PRs related to this before merging, but if nothing changes I'll merge after those.

@WardBrian WardBrian marked this pull request as ready for review November 29, 2021 15:16
@WardBrian WardBrian merged commit 456c9a5 into master Nov 29, 2021
@WardBrian WardBrian deleted the deprecation-policy-update branch November 29, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants