Make get_cmdstan_flags() robust to noisy make output#1163
Open
Make get_cmdstan_flags() robust to noisy make output#1163
get_cmdstan_flags() robust to noisy make output#1163Conversation
Fixes #1162 Parse `make print-<FLAG>` output line-by-line so cmdstanr ignores unrelated `make` chatter such as directory-entering messages triggered by `MAKEFLAGS=-w`. This fixes a failure where `get_cmdstan_flags("STANCFLAGS")` could return junk tokens, which then caused `cmdstan_model()` to error when checking local stanc flags. Also: - return `character(0)` for empty `STANCFLAGS` - use a length-safe check when combining local stanc flags - add regression tests for noisy make output, realistic continued `STANCFLAGS`, and the reported `MAKEFLAGS="-w -j 4"` case
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1163 +/- ##
==========================================
- Coverage 90.85% 90.85% -0.01%
==========================================
Files 14 14
Lines 5908 5924 +16
==========================================
+ Hits 5368 5382 +14
- Misses 540 542 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Fixes #1162
Parse
make print-<FLAG>output line-by-line so cmdstanr ignores unrelatedmakechatter such as directory-entering messages triggered byMAKEFLAGS=-w. This fixes a failure whereget_cmdstan_flags("STANCFLAGS")could return junk tokens, which then causedcmdstan_model()to error when checking local stanc flags.Also:
character(0)for emptySTANCFLAGSCopyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Jonah Gabry (codex assisted with debugging, writing test code, and writing the PR summary)
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: