-
-
Notifications
You must be signed in to change notification settings - Fork 65
New pkgdown theme and workflow #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1118 +/- ##
=======================================
Coverage 87.15% 87.15%
=======================================
Files 14 14
Lines 5973 5973
=======================================
Hits 5206 5206
Misses 767 767 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for working on this. Don't worry if sometimes you get failures in the Mac unit tests (unless they're related to something you changed). Two or three of the tests of cmdstan installation occasionally fail on GHA. Looks like that's what's happening on |
|
The site has been pushed to gh-pages but the deployment should be checked once by swapping the repo. The GHA didn't fail so I hope it works but should check. |
If I change it to gh-pages in the repo settings will that automatically trigger the deployment? |
|
Yeah it should work |
|
Ok I'll try changing the settings now |
|
I just changed the settings to use gh-pages root. |
|
Ok that seemed to work for generating the dev site. I forget, should I just leave the updated settings or should I switch it back now until we do the next release? |
|
Could leave it since the main site is unchanged. |
|
Awesome, this looks good. Will merge now! |
No description provided.