Skip to content

Conversation

@VisruthSK
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.15%. Comparing base (63ce609) to head (04c56ef).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1118   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files          14       14           
  Lines        5973     5973           
=======================================
  Hits         5206     5206           
  Misses        767      767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jgabry
Copy link
Member

jgabry commented Dec 1, 2025

Thanks for working on this. Don't worry if sometimes you get failures in the Mac unit tests (unless they're related to something you changed). Two or three of the tests of cmdstan installation occasionally fail on GHA. Looks like that's what's happening on macOS-latest (release) right now.

@VisruthSK
Copy link
Member Author

The site has been pushed to gh-pages but the deployment should be checked once by swapping the repo. The GHA didn't fail so I hope it works but should check.

@VisruthSK VisruthSK marked this pull request as ready for review December 2, 2025 04:45
@VisruthSK VisruthSK requested a review from jgabry December 2, 2025 04:45
@jgabry
Copy link
Member

jgabry commented Dec 2, 2025

The site has been pushed to gh-pages but the deployment should be checked once by swapping the repo. The GHA didn't fail so I hope it works but should check.

If I change it to gh-pages in the repo settings will that automatically trigger the deployment?

@VisruthSK
Copy link
Member Author

Yeah it should work

@jgabry
Copy link
Member

jgabry commented Dec 3, 2025

Ok I'll try changing the settings now

@jgabry
Copy link
Member

jgabry commented Dec 3, 2025

I just changed the settings to use gh-pages root.

@jgabry
Copy link
Member

jgabry commented Dec 3, 2025

Ok that seemed to work for generating the dev site. I forget, should I just leave the updated settings or should I switch it back now until we do the next release?

@VisruthSK
Copy link
Member Author

Could leave it since the main site is unchanged.

@jgabry
Copy link
Member

jgabry commented Dec 3, 2025

Awesome, this looks good. Will merge now!

@jgabry jgabry merged commit 1d58078 into master Dec 3, 2025
11 of 12 checks passed
@jgabry jgabry deleted the new-pkgdown-theme branch December 3, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants