Reserve redemption assets#724
Closed
evgeny-stakewise wants to merge 3 commits into
Closed
Conversation
Contributor
Author
There was a problem hiding this comment.
A lot of rework in this file.
Previously:
distribute_meta_vault_redemption_assets- and
get_meta_vault_redemption_assets
looked similar. Separation of concerns was unclear. - Also there was recursion.
Now:
distribute_meta_vault_redemption_assets- does the main job of distributing assets deeplyget_sub_vaults_redemptions- distributes from meta vault to direct sub vaults- Recursion was replaced with queue.
| if nonce == 0: | ||
| logger.info('Zero nonce for redemption. Skipping redemption assets.') | ||
| return Wei(0) | ||
| logger.debug('Zero nonce for redemption. Skipping redemption assets.') |
Contributor
Author
There was a problem hiding this comment.
Changed to debug to avoid spamming on each block.
evgeny-stakewise
changed the title
Contributor
Author
|
Closed in favor of #726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.