feat: ledger live support #13

petar-omni · 2026-01-23T12:46:11Z

No description provided.

vercel · 2026-01-23T12:46:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
perps-widget	Ready	Preview, Comment	Jan 25, 2026 4:46pm

socket-security · 2026-01-23T12:46:45Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@base-ui/react@1.0.0 ⏵ 1.1.0
@tanstack/react-router-devtools@1.145.7 ⏵ 1.157.8	^-25		⁺¹
@effect-atom/atom-react@0.4.4 ⏵ 0.4.6	⁺¹	⁺¹
@effect/platform-node@0.104.0 ⏵ 0.104.1			⁺²
@tanstack/router-plugin@1.145.7 ⏵ 1.157.8	⁺¹	⁺¹	⁺¹
wagmi@3.3.2 ⏵ 3.4.1	^-20		⁺¹
vitest@3.2.4 ⏵ 4.0.18	^-1	⁺¹
@types/react@19.2.7 ⏵ 19.2.9	⁺¹	⁺¹
@tanstack/devtools-vite@0.3.12 ⏵ 0.4.1	⁺¹	⁺¹	⁺³
@tanstack/react-router@1.145.7 ⏵ 1.157.8	^-19	⁺¹	⁺¹
@types/node@22.19.3 ⏵ 25.0.10
vite@7.3.0 ⏵ 7.3.1		⁺¹
@reown/appkit-adapter-wagmi@1.8.16 ⏵ 1.8.17	⁺¹
@vitest/browser-playwright@4.0.18
@reown/appkit@1.8.16 ⏵ 1.8.17		⁺¹
@tanstack/react-devtools@0.7.11 ⏵ 0.9.2	⁺¹	⁺¹	⁺²
@tanstack/react-query@5.90.16 ⏵ 5.90.20		⁺¹	⁺²
vite-plugin-node-polyfills@0.24.0 ⏵ 0.25.0		⁺¹	⁺¹
effect@3.19.14 ⏵ 3.19.15	^-1	⁺¹	⁺²
@ledgerhq/wallet-api-client@1.12.6
@testing-library/react@16.3.1 ⏵ 16.3.2			⁺⁵
vitest-browser-react@2.0.4
lucide-react@0.544.0 ⏵ 0.563.0	⁺¹	⁺²
@effect/platform@0.94.1 ⏵ 0.94.2		⁺¹
@biomejs/biome@2.3.11 ⏵ 2.3.12	⁺¹		⁺²
@effect/language-service@0.64.1 ⏵ 0.72.0	⁺⁶	⁺¹	⁺³

View full report

Copilot

Pull request overview

Adds Ledger Live (embedded dApp browser) wallet support by abstracting signing behind a Signer interface and adapting the app’s wallet/runtime flow to work with either a browser wallet (Reown/AppKit + wagmi) or Ledger Live APIs.

Changes:

Introduces Signer abstraction with separate Browser and Ledger implementations and updates WalletService to use it.
Updates wallet/domain models and UI/atoms to support multi-account switching and to key portfolio/token state by wallet address.
Adds Ledger Live manifest + dependency updates and refines a few dialog trigger patterns and numeric formatting.

Reviewed changes

Copilot reviewed 40 out of 42 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
src/services/wallet/wallet-service.ts	Refactors signing flow to use `Signer` and emits wallet state from signer account stream.
src/services/wallet/signer.ts	Adds `Signer` context contract (accounts stream, sign tx, switch account).
src/services/wallet/ledger-signer/utils.ts	Ledger Live helper utilities (accounts/currencies filtering + embed detection).
src/services/wallet/ledger-signer/index.ts	Implements Ledger Live signer layer using `@ledgerhq/wallet-api-client`.
src/services/wallet/browser-signer.ts	Implements browser signer layer with AppKit + wagmi actions.
src/services/runtime.ts	Chooses signer implementation at runtime and wires layers together.
src/services/config.ts	Makes `VITE_REOWN_PROJECT_ID` optional via `Config.option`.
src/lib/utils.ts	Adds `truncateNumber` helper to avoid rounding up in UI amounts.
src/domain/wallet.ts	Updates wallet/account domain types for browser vs ledger and adds switchAccount.
src/domain/transactions.ts	Reworks transaction schemas and adds `TransactionHash` branding.
src/domain/chains/ledger.ts	Adds Ledger family/currency mapping for supported EVM chains.
src/domain/chains/evm.ts	Narrows supported EVM chain list used by the app.
src/context/appkit.tsx	Gates wagmi provider usage based on wallet type.
src/components/molecules/tp-sl-dialog.tsx	Adjusts dialog trigger usage.
src/components/molecules/address-switcher.tsx	Replaces AppKit account UI with in-app account switch + copy/disconnect actions.
src/components/molecules/account-value-display.tsx	Keys provider-balance selection by wallet address.
src/components/modules/Root/PreloadAtoms.tsx	Preloads connected-state atoms using wallet address keys.
src/components/modules/PositionDetails/Overview/index.tsx	Keys positions atom by wallet address.
src/components/modules/PositionDetails/Overview/Position/index.tsx	Keys positions/orders atoms by wallet address.
src/components/modules/PositionDetails/Overview/Orders/index.tsx	Updates cancel order flow to pass wallet address.
src/components/modules/PositionDetails/Close/state.tsx	Refactors close-position state to use wallet address (not wallet object).
src/components/modules/PositionDetails/Close/index.tsx	Updates hook usage to pass wallet address.
src/components/modules/Order/Overview/state.tsx	Uses wallet address for balance atoms; switches to `truncateNumber`.
src/components/modules/Order/Overview/order-type-dialog.tsx	Adjusts dialog trigger usage.
src/components/modules/Order/Overview/limit-price-dialog.tsx	Adjusts dialog trigger usage.
src/components/modules/Order/Overview/leverage-dialog.tsx	Adjusts dialog trigger usage.
src/components/modules/Home/index.tsx	Adjusts connect/address-switcher behavior for browser vs ledger wallet types.
src/components/modules/Home/Positions/index.tsx	Keys portfolio atoms by wallet address.
src/components/modules/Account/balance.tsx	Keys providers balances atom by wallet address.
src/components/modules/Account/Withdraw/state.tsx	Keys selected balances by address; switches to `truncateNumber`.
src/components/modules/Account/Deposit/state.tsx	Refactors deposit atoms/hooks to be keyed by wallet address; uses `truncateNumber`.
src/components/modules/Account/Deposit/index.tsx	Updates deposit UI hooks to pass wallet address.
src/atoms/wallet-atom.ts	Simplifies wallet atom to consume wallet stream and adds switchAccount atom.
src/atoms/tokens-atoms.ts	Updates Moralis token balances atom to be keyed by wallet address type.
src/atoms/position-pending-actions-atom.ts	Updates pending position action atoms to accept wallet address.
src/atoms/portfolio-atoms.ts	Refactors portfolio atoms to be keyed by wallet address (not wallet object).
src/atoms/orders-pending-actions-atom.ts	Updates cancel order atom to accept wallet address.
src/atoms/actions-atoms.ts	Refactors signing machine atoms and changes post-action invalidation behavior.
pnpm-lock.yaml	Adds Ledger Wallet API Client dependency tree.
package.json	Adds `@ledgerhq/wallet-api-client`.
ledger-manifest/manifest.dev.json	Adds Ledger Live dApp manifest for local dev embedding.
.gitignore	Ignores `opensrc/` directory.
src/components/molecules/tp-sl-dialog.tsx	Adjusts trigger rendering to children-based usage.
src/components/molecules/address-switcher.tsx	Adds account switching UI and disconnect/copy actions.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (2)

src/services/wallet/wallet-service.ts:29

WalletService declares dependencies: [ApiClientService.Default], but the runtime layer (src/services/runtime.ts) also merges ApiClientService.Default. This is redundant and makes it unclear which layer composition is intended.

For clarity, prefer one approach: either (a) remove the dependency here and provide ApiClientService.Default from runtime.ts, or (b) keep the dependency here and stop merging ApiClientService.Default separately in runtime.ts.
src/context/appkit.tsx:26

QueryClientProvider is only rendered when wallet.type === "browser". In ledger mode (or any non-browser wallet), children is returned without a React Query provider, which will break any @tanstack/react-query hooks used in the app.

Consider always wrapping children with QueryClientProvider, and only conditionally wrapping with WagmiProvider when a browser wallet (wagmi config) is available.

  if (Result.isSuccess(result) && result.value.wallet.type === "browser") {
    return (
      <WagmiProvider config={result.value.wallet.wagmiAdapter.wagmiConfig}>
        <QueryClientProvider client={qc}>{children}</QueryClientProvider>
      </WagmiProvider>
    );
  }

  return children;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-23T16:18:28Z

src/services/wallet/browser-signer.ts

+  const switchAccount = Effect.fn(
+    function* ({ account }: { account: WalletAccount }) {
+      const connection = yield* Option.fromNullable(
+        wagmiAdapter.wagmiConfig.state.connections.get(account.id),
+      );
+
+      yield* Effect.tryPromise(() =>
+        switchConnection(wagmiAdapter.wagmiConfig, {
+          connector: connection.connector,
+        }),
+      );


switchAccount looks up wagmiConfig.state.connections using account.id, but accountsStateRef sets WalletAccount.id to the account address (from connection.value.accounts). connections is keyed by currentConnectionId (see nextState.current), so this lookup will always miss and account switching will fail.

Store the connection id alongside the account (or map from selected address back to the active connection) and use that key when calling switchConnection.

Copilot · 2026-01-23T16:18:29Z

src/atoms/actions-atoms.ts

+        Stream.onDone(() =>
+          Reactivity.pipe(
+            Effect.andThen((reactivity) =>
+              reactivity.invalidate(portfolioReactivityKeysArray),
+            ),
          ),
-          Stream.runForEach((val) =>
-            Effect.sync(() => ctx.setSelf(Result.success(val))),
-          ),
-          Effect.runFork,
-        );
-
-        return state;
-      }),
+        ),
+      ),


After signing completes, the code now invalidates only portfolioReactivityKeysArray. Actions include fund/withdraw (see ActionDtoAction in src/services/api-client/api-schemas.ts), which also affect token balances (Moralis) and token pricing state.

Re-add invalidation for tokensReactivityKeysArray (and any other relevant reactivity keys) so UI balances refresh immediately after these actions.

Copilot · 2026-01-23T16:18:29Z

src/domain/wallet.ts

+export const isBrowserWallet = (
+  wallet: Wallet | null,
+): wallet is WalletConnected & BrowserWallet => wallet?.type === "browser";


isBrowserWallet only checks wallet?.type === "browser" but its return type narrows to WalletConnected & BrowserWallet. This is unsound: a disconnected browser wallet will satisfy the predicate.

Either (a) also check wallet?.status === "connected", or (b) widen the return type to include disconnected browser wallets (e.g. WalletBase & BrowserWallet).

Copilot · 2026-01-23T16:18:29Z

src/services/wallet/browser-signer.ts

+export const BrowserSignerLayer = Effect.gen(function* () {
+  const projectId = yield* ConfigService.pipe(
+    Effect.andThen((config) => config.reownProjectId),
+  );
+
+  const networks: NonEmptyArray<
+    AppKitNetwork & { skChainName: SupportedSKChains }
+  > = [
+    { ...mainnet, skChainName: EvmNetworks.Ethereum },
+    { ...base, skChainName: EvmNetworks.Base },
+    { ...arbitrum, skChainName: EvmNetworks.Arbitrum },
+    { ...optimism, skChainName: EvmNetworks.Optimism },
+    { ...monad, skChainName: EvmNetworks.Monad },
+    { ...hyperLiquidL1, skChainName: EvmNetworks.HyperEVM },
+  ];
+
+  const chainsMap = Record.fromIterableBy(networks, (network) =>
+    network.id.toString(),
+  );
+
+  const wagmiAdapter = new WagmiAdapter({
+    networks,
+    projectId,
+    multiInjectedProviderDiscovery: true,


ConfigService.reownProjectId is now optional (Config.option), but BrowserSignerLayer uses it directly as projectId for WagmiAdapter/createAppKit. This will pass an Option/optional value where a string is expected and can break wallet initialization.

Unwrap/validate the project id here (fail fast with a clear error when missing), or keep VITE_REOWN_PROJECT_ID required for the browser signer path.

Copilot · 2026-01-23T16:18:30Z

src/services/wallet/ledger-signer/utils.ts

+export const isLedgerDappBrowserProvider = Option.fromNullable(window).pipe(
+  Option.map((w) => {
+    try {
+      const params = new URLSearchParams(w.self.location.search);
+
+      return !!params.get("embed");
+    } catch (_error) {
+      return false;
+    }
+  }),
+  Option.getOrElse(() => false),
+);


isLedgerDappBrowserProvider references window at module top-level. In non-browser contexts (SSR, tests, build tooling) this can throw a ReferenceError during import.

Guard with typeof window !== "undefined" (or compute lazily inside a function) before accessing window/location.

Copilot · 2026-01-23T16:18:30Z

src/domain/transactions.ts

+export const EvmTx = Schema.Struct({
+  from: Schema.String,
+  to: HexString,
+  data: HexString,


EvmTx is now an exact Schema.Struct with a fixed set of fields and no index signature. However the backend exposes TransactionDto.signablePayload as Record<string, unknown> (see src/services/api-client/api-schemas.ts:572), so additional transaction fields will cause decoding to fail and the signing flow will die.

Consider restoring an index signature (allow unknown extra props) or modeling the actual payload shape more permissively.

Copilot · 2026-01-23T16:18:30Z

src/domain/transactions.ts

+  value: Schema.optional(Schema.BigInt),
+  maxFeePerGas: Schema.optional(Schema.BigInt),
+  maxPriorityFeePerGas: Schema.optional(Schema.BigInt),
+  gasLimit: Schema.BigInt,
+  nonce: Schema.Number,


EvmTx uses Schema.BigInt for gasLimit/fees/value. Since signablePayload comes from the API as JSON (Record<string, unknown>), these numeric fields will typically arrive as strings or numbers (JSON can’t encode bigint).

Ensure the schema decodes from the JSON representation (e.g., BigInt-from-string/number), otherwise Schema.decodeUnknown(Transaction) may reject valid payloads.

feat: ledger live support

81d88d3

petar-omni force-pushed the feat/ledger-live-support branch from b5e61c0 to 81d88d3 Compare January 23, 2026 16:02

petar-omni marked this pull request as ready for review January 23, 2026 16:03

petar-omni requested review from Philippoes and Copilot January 23, 2026 16:03

Copilot started reviewing on behalf of petar-omni January 23, 2026 16:03 View session

vercel bot deployed to Preview January 23, 2026 16:03 View deployment

Copilot AI reviewed Jan 23, 2026

View reviewed changes

vercel bot deployed to Preview January 25, 2026 16:33 View deployment

petar-omni force-pushed the feat/ledger-live-support branch from 666e04a to dba2e56 Compare January 25, 2026 16:35

vercel bot deployed to Preview January 25, 2026 16:36 View deployment

petar-omni force-pushed the feat/ledger-live-support branch from dba2e56 to 52fbba6 Compare January 25, 2026 16:39

vercel bot deployed to Preview January 25, 2026 16:40 View deployment

petar-omni force-pushed the feat/ledger-live-support branch from 52fbba6 to 2ca5700 Compare January 25, 2026 16:41

vercel bot deployed to Preview January 25, 2026 16:42 View deployment

test: init

d1f555f

petar-omni force-pushed the feat/ledger-live-support branch from 2ca5700 to d1f555f Compare January 25, 2026 16:46

vercel bot deployed to Preview January 25, 2026 16:46 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ledger live support #13

feat: ledger live support #13

Uh oh!

petar-omni commented Jan 23, 2026

Uh oh!

vercel bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

socket-security bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: ledger live support #13

Are you sure you want to change the base?

feat: ledger live support #13

Uh oh!

Conversation

petar-omni commented Jan 23, 2026

Uh oh!

vercel bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jan 23, 2026 •

edited

Loading

socket-security bot commented Jan 23, 2026 •

edited

Loading