Skip to content

feat: change map methods to handle errors gracefully#6893

Merged
melcar-stacks merged 4 commits intostacks-network:feat/clarity-wasm-developfrom
melcar-stacks:feat/maps-methods-changes-for-cost
Mar 17, 2026
Merged

feat: change map methods to handle errors gracefully#6893
melcar-stacks merged 4 commits intostacks-network:feat/clarity-wasm-developfrom
melcar-stacks:feat/maps-methods-changes-for-cost

Conversation

@melcar-stacks
Copy link
Copy Markdown

This is the PR corresponding to this one in clarity wasm

@melcar-stacks melcar-stacks requested a review from a team as a code owner February 12, 2026 15:34
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 12, 2026

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 41.93548% with 54 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.97%. Comparing base (7d092de) to head (dfdd783).
⚠️ Report is 5 commits behind head on feat/clarity-wasm-develop.

Files with missing lines Patch % Lines
clarity/src/vm/clarity_wasm.rs 41.93% 54 Missing ⚠️

❌ Your project status has failed because the head coverage (41.97%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                      Coverage Diff                       @@
##           feat/clarity-wasm-develop    #6893       +/-   ##
==============================================================
+ Coverage                      28.25%   41.97%   +13.71%     
==============================================================
  Files                            572      399      -173     
  Lines                         353459   219799   -133660     
==============================================================
- Hits                           99887    92255     -7632     
+ Misses                        253572   127544   -126028     
Files with missing lines Coverage Δ
clarity/src/vm/clarity_wasm.rs 38.25% <41.93%> (+0.67%) ⬆️

... and 324 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d092de...dfdd783. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

For the cost compution of map's methods we need to compute the cost and
then throwback the error when an error occurs. This forced us to handle
errors better.
@melcar-stacks melcar-stacks force-pushed the feat/maps-methods-changes-for-cost branch from eeae600 to fc09938 Compare March 17, 2026 13:45
Acaccia-stacks
Acaccia-stacks previously approved these changes Mar 17, 2026
Comment thread clarity/src/vm/clarity_wasm.rs
Comment thread clarity/src/vm/clarity_wasm.rs
Copy link
Copy Markdown

@bogdan-stacks bogdan-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melcar-stacks melcar-stacks added this pull request to the merge queue Mar 17, 2026
Merged via the queue into stacks-network:feat/clarity-wasm-develop with commit b289da0 Mar 17, 2026
1 of 2 checks passed
@melcar-stacks melcar-stacks deleted the feat/maps-methods-changes-for-cost branch March 17, 2026 16:03
@github-actions
Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants