fix: replace yaml lib #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
requested review from
GrimmiMeloni and
porridge
and removed request for
a team
porridge
approved these changes
Jul 14, 2025
Contributor
porridge
left a comment
porridge
left a comment
There was a problem hiding this comment.
❤️
Before merging, it might make sense to bump https://github.com/stackrox/stackrox/pull/15834/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6 (or its clone) to use this version to make sure everything still works when integrated.
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com> # Conflicts: # go.mod
janisz
force-pushed
the
fix_yaml_lib
branch
2 times, most recently
from
e608552 to
0d327c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gopkg.in/yamlis not maintained let's follow k8s recommendation and use"go.yaml.in/yaml/v3"alternatively we could use https://github.com/goccy/go-yaml but we already have indirect dependency to k8s version and it's a fork ofgithub.com/ghodss/yamlso we can replace 2 deps with 1 without any code changes.See: