[pull] master from sdkman:master#105
Open
pull[bot] wants to merge 134 commits intostackriot-labs:masterfrom
Open
[pull] master from sdkman:master#105pull[bot] wants to merge 134 commits intostackriot-labs:masterfrom
pull[bot] wants to merge 134 commits intostackriot-labs:masterfrom
Conversation
* Add Homebrew formula template * Add brew packager * Remove selfupdate functionality when installed via Homebrew * Configure JRELEASER_HOMEBREW_GITHUB_TOKEN * Order configuration alphabetically
* Add platform to appease Homebrew packager * Add explanatory comment
Only fall back on Linuxx64 on platforms not mentioned in https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py#L56 (excluding the i*86 platforms)
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [kentaro-m/auto-assign-action](https://github.com/kentaro-m/auto-assign-action) from 1.1.2 to 1.2.1. - [Release notes](https://github.com/kentaro-m/auto-assign-action/releases) - [Commits](kentaro-m/auto-assign-action@v1.1.2...v1.2.1) --- updated-dependencies: - dependency-name: kentaro-m/auto-assign-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 2 to 3. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Trim PROMPT_COMMAND Without this fix there may be a message with double semicolon: bash: PROMPT_COMMAND: line 0: `history -a; history -n; ;sdkman_auto_env'
Bumps [kentaro-m/auto-assign-action](https://github.com/kentaro-m/auto-assign-action) from 1.2.1 to 1.2.3. - [Release notes](https://github.com/kentaro-m/auto-assign-action/releases) - [Commits](kentaro-m/auto-assign-action@v1.2.1...v1.2.3) --- updated-dependencies: - dependency-name: kentaro-m/auto-assign-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: switch issue triage to /hooks/wake for DM routing * chore: add workflow_run notification via /hooks/wake * chore: remove inline notify-failure (replaced by workflow_run) * chore: remove inline notify-failure (replaced by workflow_run) --------- Co-authored-by: sdkman-chloe[bot] <263185818+sdkman-chloe[bot]@users.noreply.github.com>
…ivery (#1512) Co-authored-by: chloe-sdkman[bot] <263185818+chloe-sdkman[bot]@users.noreply.github.com>
Co-authored-by: chloe-sdkman[bot] <263185818+chloe-sdkman[bot]@users.noreply.github.com>
Co-authored-by: chloe41427[bot] <263185818+chloe41427[bot]@users.noreply.github.com>
Co-authored-by: chloe41427[bot] <263185818+chloe41427[bot]@users.noreply.github.com>
- Remove `sdk offline` command and all associated code - Delete offline_mode.feature entirely - Replace SDKMAN_OFFLINE_MODE env var with sdkman_healthcheck_enable config flag - When sdkman_healthcheck_enable=false, skip the startup healthcheck entirely (SDKMAN_AVAILABLE stays true; commands proceed and fail naturally if offline) - Update INTERNET NOT REACHABLE warning to reference new config option - Rename __sdkman_display_offline_warning -> __sdkman_display_network_warning - Remove withOfflineMode() from SdkmanBashEnvBuilder and test step definitions - Update service_unavailable.feature: drop offline-list fallback scenarios, update error message strings to match new wording - Remove offline from bash completion script - Fixes #1484 (sdk offline was triggering network traffic before mode engaged) - Closes #1517
Missed EnvCommandSpec, CurrentCommandSpec, and ConfigCommandSpec which still called withOfflineMode() on SdkmanBashEnvBuilder after the method was removed.
- Use $SDKMAN_DIR instead of hardcoded ~/.sdkman in network warning - Add hint to open a new terminal after changing config - Restore offline list fallback for 'sdk list <candidate>' when internet is unreachable (renamed to __sdkman_installed_versions) - Restore offline list test scenarios in service_unavailable.feature
Reword the INTERNET NOT REACHABLE warning to explain that SDKMAN! needs an active connection, and that the healthcheck config is for users whose connection is active but slow — not a fix for no internet.
Updates length from 15 (shorter than 12 existing 'java' candidates) to 20 (longer than any existing 'java' candidate). Fixes: #1526
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )