Skip to content

Support custom summarize timestamp column#40

Merged
stacknil merged 1 commit into
mainfrom
stacknil/summarize-custom-timestamp-column
May 18, 2026
Merged

Support custom summarize timestamp column#40
stacknil merged 1 commit into
mainfrom
stacknil/summarize-custom-timestamp-column

Conversation

@stacknil
Copy link
Copy Markdown
Owner

Summary

  • add --timestamp-col to the summarize CLI command
  • make summarize validate and normalize custom timestamp columns consistently with run
  • document the summarize inspection command and add CLI coverage for custom timestamp columns

Tests

  • pytest tests/test_cli_summarize.py tests/test_cli_errors.py tests/test_io.py
  • pytest
  • python -m telemetry_window_demo.cli run --config configs/default.yaml

@stacknil stacknil merged commit 24e86fb into main May 18, 2026
2 checks passed
@stacknil stacknil deleted the stacknil/summarize-custom-timestamp-column branch May 18, 2026 02:47
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 792112fdff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
- `python -m telemetry_window_demo.cli summarize --input data/raw/sample_events.jsonl`
- `python -m telemetry_window_demo.cli summarize --input events.csv --timestamp-col event_time`

That command reads `data/raw/sample_events.jsonl` and regenerates:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Point output artifact claim to the run command

After adding the summarize examples, the sentence “That command reads data/raw/sample_events.jsonl and regenerates:” now follows the summarize bullets, but summarize only prints stats and does not write features.csv, alerts.csv, or plots. This README flow now misstates actual CLI behavior and can mislead users reproducing outputs; the sentence should explicitly reference python -m telemetry_window_demo.cli run --config configs/default.yaml (or be moved back under that command).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant