Skip to content

Improve code-review-assist skill from review sessions#4321

Merged
jerm-dro merged 1 commit intomainfrom
improve-code-review-assist-skill
Mar 23, 2026
Merged

Improve code-review-assist skill from review sessions#4321
jerm-dro merged 1 commit intomainfrom
improve-code-review-assist-skill

Conversation

@jerm-dro
Copy link
Contributor

Summary

  • Review sessions on March 20 and 23 revealed recurring gaps in the code-review-assist skill: missing leaky abstractions, not flagging in-place mutations, inconsistent comment severity, and suggesting non-idiomatic code patterns. This codifies those learnings into the skill so future sessions benefit immediately.
  • Add abstraction integrity check to Key Review Questions — flags interface methods that only work for one implementation, type casts on interfaces, and other leaky abstraction signals
  • Add mutation of shared state check — flags in-place mutation of long-lived or shared data structures and suggests immutable alternatives
  • Add Comment Format section requiring conventional comments (blocker:, suggestion:, nitpick:, question:) with severity calibration guidance
  • Add Code Suggestions section requiring .claude/rules/ lookup before suggesting code and concrete examples for external contributors

Type of change

  • Other (describe): Claude Code skill improvement

Test plan

  • Manual testing (describe below)

Validated against three PRs reviewed in the March 23 session (#4236, #4313, #4318) where these gaps were identified. Each addition directly addresses a documented miss in review-session-notes.md.

Does this introduce a user-facing change?

No

Generated with Claude Code

Add abstraction integrity checks, mutation flagging, conventional
comments format, and project-aware code suggestion guidelines
learned from review sessions where the skill missed leaky
abstractions, in-place mutations, used inconsistent severity,
and suggested non-idiomatic code patterns.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Mar 23, 2026
@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.81%. Comparing base (efb15e9) to head (5c333eb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4321      +/-   ##
==========================================
- Coverage   68.83%   68.81%   -0.03%     
==========================================
  Files         478      478              
  Lines       48288    48306      +18     
==========================================
  Hits        33241    33241              
- Misses      12343    12348       +5     
- Partials     2704     2717      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jerm-dro jerm-dro merged commit 35d2fc0 into main Mar 23, 2026
37 checks passed
@jerm-dro jerm-dro deleted the improve-code-review-assist-skill branch March 23, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants