Add TOML client config support for Mistral Vibe and Codex #3592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the client configuration system to support TOML-based config files with two different formats: - Array-of-tables format `[[section]]` for Mistral Vibe IDE - Nested tables format `[section.servername]` for Codex CLI Key changes: - Add TOMLConfigUpdater for array-of-tables format (Mistral Vibe) - Add TOMLMapConfigUpdater for nested tables format (Codex) - Add MistralVibe and Codex client types with transport mappings - Add TOMLStorageType enum to distinguish between TOML formats - Support TOML extension alongside JSON and YAML - Add comprehensive tests for both TOML updater implementations - Extract defaultURLFieldName constant to reduce duplication - Improve validation to handle empty YAML/TOML files correctly Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
aponcedeleonch
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
dmjb,
eleftherias,
jhrozek,
lujunsan,
rdimitrov and
yrobla
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
==========================================
+ Coverage 65.51% 65.59% +0.08%
==========================================
Files 406 406
Lines 39996 40176 +180
==========================================
+ Hits 26202 26354 +152
- Misses 11762 11768 +6
- Partials 2032 2054 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3586 , #3553
Extends the client configuration system to support TOML-based config files with two different formats:
[[section]]for Mistral Vibe IDE[section.servername]for Codex CLIKey changes: