Add optimizer packages and infrastructure (non-functional)#3516
Open
Add optimizer packages and infrastructure (non-functional)#3516
Conversation
This PR adds the core optimizer implementation without wiring it into the server startup. The optimizer provides semantic tool discovery using embeddings to reduce token usage for LLMs working with large toolsets. Changes include: - New optimizer internal packages (db, embeddings, ingestion, models, tokens) - EmbeddingOptimizer implementation with hybrid search (semantic + FTS) - Updated Optimizer interface with Close() and HandleSessionRegistration() - OptimizerHandlerProvider interface in adapter package - Config schema updates for optimizer configuration - CRD schema updates for VirtualMCPServer optimizer fields - Updated dummy_optimizer to implement new interface (backward compat) - Test updates for new schema structure This is part 1 of a 3-part PR split. Part 2 will wire the optimizer into server startup. Part 3 will add documentation and examples.
therealnb
requested review from
ChrisJBurns,
JAORMX,
amirejaz,
jerm-dro,
jhrozek and
yrobla
as code owners
This was referenced Jan 29, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the core optimizer implementation without wiring it into the server startup. The optimizer provides semantic tool discovery using embeddings to reduce token usage for LLMs working with large toolsets.
This is part 1 of a 3-part PR split from #3440:
Changes
New Optimizer Packages (
pkg/vmcp/optimizer/internal/)db/: SQLite database with FTS5 full-text searchembeddings/: Embedding providers (Ollama, OpenAI-compatible)ingestion/: Tool ingestion servicemodels/: Data models and transport typestokens/: Token counting utilitiesCore Optimizer (
pkg/vmcp/optimizer/)EmbeddingOptimizerimplementation with hybrid search (semantic + FTS)Optimizerinterface withClose()andHandleSessionRegistration()dummy_optimizer.goto implement new interface (backward compat)Config & Schema
OptimizerHandlerProviderinterface in adapter packageTests
Test Plan