This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Conversation
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
Member
Author
|
I think I should comment the vllm redacting secret test or use our hosted vllm server otherwise the integration tests will take around 40minutes to complete and that's not practical. |
Contributor
Please do, the redaction shouldn't be depending on the provider anyway |
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
jhrozek
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR adds tests for redacting secrets to all providers from chat.
Fixes: #952