This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Conversation
rdimitrov
force-pushed
the
malicious-vllm
branch
from
1eb20de to
bb1708f
Compare
aponcedeleonch
previously approved these changes
Feb 5, 2025
rdimitrov
dismissed
aponcedeleonch’s stale review
hey, let's not merge it yet, it doesn't seem stable enough
rdimitrov
force-pushed
the
malicious-vllm
branch
from
bb1708f to
7ad735b
Compare
Signed-off-by: Radoslav Dimitrov <radoslav@stacklok.com>
rdimitrov
force-pushed
the
malicious-vllm
branch
from
7ad735b to
0f0f444
Compare
Member
Author
|
I had to update the malicious package test case for this and the rest of the local providers because of the capabilities of the 0.5B model we are using for these tests. It looks like it cannot handle the system prompts as precisely as we expect which results in non-deterministic responses, i.e. sometimes it includes example code snippets even though it says the package is malicious, sometimes it doesn't include the link to insights. To handle all of this decided to simplify the test and just check if CodeGate was able to flag it. |
jhrozek
approved these changes
Feb 5, 2025
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
the functionality is shared across the providers, so I think this is good enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR adds malicious package test for vllm.
Related to: #904