This repository was archived by the owner on Jul 23, 2025. It is now read-only.
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
Author
|
@peppescg I cribbed some of this from your additions to codegate-ui, so tagging you for a review 😄 |
|
That's amazing @danbarr 🚀 |
peppescg
reviewed
Jan 7, 2025
peppescg
reviewed
Jan 7, 2025
peppescg
left a comment
peppescg
left a comment
There was a problem hiding this comment.
I have question, usually in FE repo we use husky for adding precommit hook, checking eslint, typescript issues before commit...I don't know if it could be helpful also here...in case you consider it helpful I can help on this ( consider that in codegate-ui I installed it last week )
peppescg
previously approved these changes
Jan 7, 2025
peppescg
left a comment
peppescg
left a comment
There was a problem hiding this comment.
Great work 👏
I would add a precommit hook and a script for markdown lint, having the tools during the development flow too, but it could be added in a next PR too, so I approve 👍
JAORMX
previously approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds configs for Prettier, markdownlint, and ESLint. Also adds GitHub Actions to run them and a test build on PRs.