chore(modelserving): switch to new SDK structure#1377
Open
Conversation
s-inter
changed the title
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
s-inter
commented
Apr 15, 2026
Comment on lines
+590
to
594
| // theoretically, should never happen, but still catch zero values | ||
| validUntil := types.StringNull() | ||
| if tokenGetResp.Token.ValidUntil != nil { | ||
| if !tokenGetResp.Token.ValidUntil.IsZero() { | ||
| validUntil = types.StringValue(tokenGetResp.Token.ValidUntil.Format(time.RFC3339)) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I'd say this check isn't needed anymore—I'd remove it. But I'd like another opinion.
Contributor
There was a problem hiding this comment.
I'd also remove it, the old code would also just have assigned a 0-value
cgoetz-inovex
approved these changes
Apr 15, 2026
Comment on lines
+590
to
594
| // theoretically, should never happen, but still catch zero values | ||
| validUntil := types.StringNull() | ||
| if tokenGetResp.Token.ValidUntil != nil { | ||
| if !tokenGetResp.Token.ValidUntil.IsZero() { | ||
| validUntil = types.StringValue(tokenGetResp.Token.ValidUntil.Format(time.RFC3339)) | ||
| } |
Contributor
There was a problem hiding this comment.
I'd also remove it, the old code would also just have assigned a 0-value
Comment on lines
+250
to
+251
| Description: utils.Ptr("desc"), | ||
| TtlDuration: utils.Ptr("1h"), |
Contributor
There was a problem hiding this comment.
running go fix would reintroduce using new instead of utils.Ptr
Comment on lines
+302
to
+303
| Name: utils.Ptr("name"), | ||
| Description: utils.Ptr("desc"), |
| } | ||
| if utils.Contains(tokensToDestroy, *items[i].Name) { | ||
| _, err := client.DeleteToken(ctx, testutil.Region, testutil.ProjectId, *items[i].Id).Execute() | ||
| if utils.Contains(tokensToDestroy, items[i].Name) { |
Contributor
There was a problem hiding this comment.
could use slices.Contains instead of custom utility func
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITTPR-563
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)